From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver Date: Sat, 16 Apr 2011 07:58:30 -0700 Message-ID: <20110416145830.GA8811@kroah.com> References: <201104161200.32042.heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from kroah.org ([198.145.64.141]:48942 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754581Ab1DPO6V (ORCPT ); Sat, 16 Apr 2011 10:58:21 -0400 Content-Disposition: inline In-Reply-To: <201104161200.32042.heiko@sntech.de> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Alan Stern , Kukjin Kim , Ben Dooks , Thomas Abraham , Sangbeom Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, Alexander Neumann On Sat, Apr 16, 2011 at 12:00:31PM +0200, Heiko St=FCbner wrote: > Am Donnerstag 14 April 2011, 19:15:23 schrieb Alan Stern: > > On Thu, 14 Apr 2011, Greg KH wrote: > > > On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote: > > > > On Thu, 14 Apr 2011, Heiko [iso-8859-1] St?bner wrote: > > > > > From: Thomas Abraham > > > > >=20 > > > > > The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB Hig= h-Speed > > > > > device controller module. This driver enables support for USB > > > > > high-speed gadget functionality for the Samsung S3C24xx SoC's= that > > > > > include this controller. > > > > >=20 > > > > > Signed-off-by: Thomas Abraham > > > > > Signed-off-by: Sangbeom Kim > > > > > Signed-off-by: Kukjin Kim > > > > > Signed-off-by: Alexander Neumann > > > > > Signed-off-by: Heiko Stuebner > > > >=20 > > > > ... > > > >=20 > > > > > +static struct usb_ep_ops s3c_hsudc_ep_ops =3D { > > > > > + .enable =3D s3c_hsudc_ep_enable, > > > > > + .disable =3D s3c_hsudc_ep_disable, > > > > > + .alloc_request =3D s3c_hsudc_alloc_request, > > > > > + .free_request =3D s3c_hsudc_free_request, > > > > > + .queue =3D s3c_hsudc_queue, > > > > > + .dequeue =3D s3c_hsudc_dequeue, > > > > > + .set_halt =3D s3c_hsudc_set_halt, > > > > > +}; > > > >=20 > > > > There's no .set_wedge method. Why do people always leave this = out? > > >=20 > > > Does the code spit out a nasty warning if this isn't set? If not= , I > > > would suggest adding it so that this doesn't keep happening. > > >=20 > > > Or just refuse to be able to register the structure, that would s= top it > > > right away :) > >=20 > > In fact, set_wedge is optional. But it's so easy to implement, the= re's > > no good reason for leaving it out. >=20 > It seems Thomas [original author of the driver] will be able to imple= ment said=20 > set_wedge function for it. > As he will need a bit of time for this, two possible ways for going f= orward=20 > come to mind: > (1) use current driver [as set_wedge is optional] and add it later vi= a patch > (2) resubmit whole driver again when set_wedge is added to it >=20 > Obviously I would prefer option 1 :-), but in the end it's your decis= ion. It shouldn't take that much time to do this, what is the delay? I'd prefer to get the correct version implemented and would not like to accept a patch that everyone knows is wrong. thanks, greg k-h