From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
patches@opensource.wolfsonmicro.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] ARM: S3C6410: Use device names for both I2C clocks
Date: Tue, 8 Nov 2011 16:36:00 +0000 [thread overview]
Message-ID: <20111108163600.GF5632@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAJuYYwTM4M-dt6mMgOH2TLEbBx7CgmiNVaB2VqYN-YMLYHqaZg@mail.gmail.com>
On Tue, Nov 08, 2011 at 09:57:56PM +0530, Thomas Abraham wrote:
> On 8 November 2011 21:39, Mark Brown
> > +#ifdef CONFIG_S3C_DEV_I2C1
> > + .devname = "s3c2440-i2c.0",
> > +#else
> > + .devname = "s3c2440-i2c",
> > +#endif
> The #ifdef around the id of the s3c_device_i2c0 structure in
> arch/arm/plat-samsung/devs.c file can be removed and id can be fixed
> as 0. And devname "s3c2440-i2c.0" can be assigned above without the
> #ifdef. Will there be any issues in using .id as 0 even if there is
> only one instance of i2c?
That would be much nicer from my point of view but it's much more
invasive as this device is used by a whole raft of other SoCs, not all
of which have more than one I2C controller and I don't really feel like
changing the idiom over the entire Samsung SoC family right now.
prev parent reply other threads:[~2011-11-08 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1320768593-21010-1-git-send-email-broonie@opensource.wolfsonmicro.com>
2011-11-08 16:27 ` [PATCH] ARM: S3C6410: Use device names for both I2C clocks Thomas Abraham
2011-11-08 16:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108163600.GF5632@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox