From: Felipe Balbi <balbi@ti.com>
To: Praveen Paneri <p.paneri@samsung.com>
Cc: linux-usb@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
balbi@ti.com, gregkh@linuxfoundation.org,
thomas.abraham@linaro.org, ben-linux@fluff.org,
broonie@opensource.wolfsonmicro.com, l.majewski@samsung.com,
kyungmin.park@samsung.com, grant.likely@secretlab.ca,
heiko@sntech.de
Subject: Re: [PATCH v4 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Date: Fri, 10 Aug 2012 10:06:24 +0300 [thread overview]
Message-ID: <20120810070623.GL1689@arwen.pp.htv.fi> (raw)
In-Reply-To: <1344582631-13658-1-git-send-email-p.paneri@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]
On Fri, Aug 10, 2012 at 12:40:26PM +0530, Praveen Paneri wrote:
> Changes from v3:
> Replaced susbsys_initcall()/module_exit() by module_platform_driver().
> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver
> is registered
> Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove.
>
> Changes from v2:
> Changed the driver filenames to samsung-usbphy
> Changed 's3c' to 'samsung' for platform device as well as platform data
> Moved platform data structure to a separate file
> Rectified coding style related errors
>
> Changes from v1:
> Rebased patches to latest usb-next branch
> Changed the name 'sec_usbphy' to 'samsung_usbphy'
>
> This patch set introduces a phy driver for samsung SoCs. It uses the existing
> transceiver infrastructure to provide phy control functions. Use of this driver
> can be extended for usb host phy as well. Over the period of time all the phy
> related code for most of the samsung SoCs can be integrated here.
> Removing the existing phy code from mach-s3c64xx. Same can be done for other SoCs
> when they start supporting this phy driver.
> This driver is tested with smdk6410 and Exynos4210(with DT).
>
> Praveen Paneri (5):
> usb: phy: samsung: Introducing usb phy driver for hsotg
> usb: s3c-hsotg: Adding phy driver support
> ARM: S3C64XX: Removing old phy setup code
> ARM: S3C64XX: Enabling samsung-usbphy driver
> ARM: Exynos4210: Enabling samsung-usbphy driver
just one idea. It looks like after introducing the PHY, you converted
all users to create the phy device. I wonder if you should have a
patch 6/6 which will remove pdata->init support from s3c_hsotg.c and
stick to using phy driver.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-10 7:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 7:10 [PATCH v4 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Praveen Paneri
2012-08-10 7:06 ` Felipe Balbi [this message]
[not found] ` <20120810070623.GL1689-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-08-10 7:34 ` Praveen Paneri
2012-08-10 7:40 ` Felipe Balbi
2012-08-10 7:10 ` [PATCH v4 3/5] ARM: S3C64XX: Removing old phy setup code Praveen Paneri
[not found] ` <1344582631-13658-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-08-10 7:10 ` [PATCH v4 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg Praveen Paneri
[not found] ` <1344582631-13658-2-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-08-10 7:04 ` Felipe Balbi
2012-08-10 7:16 ` Praveen Paneri
2012-08-10 7:19 ` ABRAHAM, KISHON VIJAY
[not found] ` <CAAe_U6K=h7gP+fTQTkzP_WQfccVMYhG+UtsLprDMrsozuBywoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-10 7:36 ` Praveen Paneri
2012-08-10 7:10 ` [PATCH v4 2/5] usb: s3c-hsotg: Adding phy driver support Praveen Paneri
2012-08-10 7:10 ` [PATCH v4 4/5] ARM: S3C64XX: Enabling samsung-usbphy driver Praveen Paneri
2012-08-10 7:10 ` [PATCH v4 5/5] ARM: Exynos4210: " Praveen Paneri
2012-09-11 8:47 ` [PATCH v4 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810070623.GL1689@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.paneri@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox