Linux Samsung SOC development
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Grant Likely' <grant.likely@secretlab.ca>,
	'Rob Herring' <rob.herring@calxeda.com>,
	'Rob Landley' <rob@landley.net>,
	'Linus Walleij' <linus.walleij@stericsson.com>,
	'Olof Johansson' <olof@lixom.net>,
	'Thomas Abraham' <thomas.abraham@linaro.org>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v2] gpio: samsung: add devicetree init for s3c24xx arches
Date: Fri, 7 Sep 2012 09:27:27 +0200	[thread overview]
Message-ID: <201209070927.28405.heiko@sntech.de> (raw)
In-Reply-To: <243901cd8cbb$10ad0580$32071080$%kim@samsung.com>

Am Freitag, 7. September 2012, 07:38:52 schrieb Kukjin Kim:
> Heiko Stübner wrote:
> > Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs
> > via the device tree. This patch implements dt-support for the
> > s3c24xx arches.
> > 
> > The controllers contain only 3 cells, as the underlying gpio controller
> > does not support controlling the drive strength on a gpio level.
> > 
> > Tested with the gpio-keys driver on a s3c2416 based machine.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> > ---
> 
> [...]
> 
> > +#if defined(CONFIG_PLAT_S3C24XX) && defined(CONFIG_OF)
> 
> [...]
> 
> > +static __init void s3c24xx_gpiolib_attach_ofnode(struct
> > samsung_gpio_chip *chip,
> > +						 u64 base, u64 offset)
> > +{
> 
> [...]
> 
> > +}
> > +#elif defined(CONFIG_PLAT_S3C24XX)
> 
> Heiko, above line breaks building for other samsung stuff except s3c24xx. I
> fixed with following which has been amended in your patch. If any
> problems, please let me know.

yeah, I see the problem now. Thanks for the fix and sorry to have caused 
additional work.


Heiko

      reply	other threads:[~2012-09-07  7:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28 21:55 [PATCH v2] gpio: samsung: add devicetree init for s3c24xx arches Heiko Stübner
2012-08-28 23:09 ` Kukjin Kim
     [not found]   ` <503D4FB1.1020206-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-08-29  7:41     ` Heiko Stübner
2012-08-31 23:07   ` Linus Walleij
2012-09-06 22:25     ` Kukjin Kim
2012-09-07  5:38 ` Kukjin Kim
2012-09-07  7:27   ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209070927.28405.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox