From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property Date: Thu, 10 Jan 2013 15:01:21 -0800 Message-ID: <20130110230121.GA20584@quad.lixom.net> References: <1354251857-21587-1-git-send-email-dianders@chromium.org> <1357842269-15062-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1357842269-15062-1-git-send-email-dianders@chromium.org> Sender: linux-mmc-owner@vger.kernel.org To: Doug Anderson Cc: linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Thomas Abraham , Kukjin Kim , Arnd Bergmann , Will Newton , Chris Ball , Jaehoon Chung , Seungwon Jeon , linux-kernel@vger.kernel.org, Grant Likely , Rob Herring , Rob Landley , Abhilash Kesavan , Kyungmin Park , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On Thu, Jan 10, 2013 at 10:24:26AM -0800, Doug Anderson wrote: > The "disable-wp" property is used to specify that a given SD card slot > doesn't have a concept of write protect. This eliminates the need for > special case code for SD slots that should never be write protected > (like a micro SD slot or a dev board). > > The dw_mmc driver is special in needing to specify "disable-wp" > because the lack of a "wp-gpios" property means to use the special > purpose write protect line. On some other mmc devices the lack of > "wp-gpios" means that write protect should be disabled. Hi, The previous code used the controller-common quirk field to set a per-controller DW_MCI_QUIRK_NO_WRITE_PROTECT. Is there really need to do this per-slot? And if so, please explain in the commit message why there is need for a brand new quirk for the same functionality. It's even uncertain if there are any systems out there that uses the multi-slot functionality of this driver to date, most seem to map one slot per controller in the first place... -Olof