From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
Date: Mon, 1 Jul 2013 23:38:49 +0100 [thread overview]
Message-ID: <20130701223849.GR27646@sirena.org.uk> (raw)
In-Reply-To: <CAOMZO5DZb1wWu93eEHkEqNORhm_hn6qy_LdiRSumP7UODJ3uMw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Mon, Jul 01, 2013 at 06:47:00PM -0300, Fabio Estevam wrote:
> On Mon, Jul 1, 2013 at 6:36 PM, Mark Brown <broonie@kernel.org> wrote:
> > i2c@12C90000 {
> > - status = "disabled";
> > + wm1811a@11 {
> > + compatible = "wlf,wm1811";
> > + reg = <0x1a>;
> Shouldn't it be reg = <0x11> ? Or wm1811a@1a ?
The @ should change. Though since it's one of the bits of ornamental
noise DT has rules for :/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-01 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 21:36 [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
2013-07-01 21:36 ` [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
2013-07-01 21:47 ` Fabio Estevam
2013-07-01 22:38 ` Mark Brown [this message]
2013-07-02 5:21 ` Tushar Behera
2013-07-02 9:25 ` Mark Brown
2013-07-24 1:50 ` Kukjin Kim
2013-07-05 23:36 ` [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Tomasz Figa
2013-07-06 9:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701223849.GR27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox