From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Padmavathi Venna <padma.v@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
padma.kvr@gmail.com, kgene.kim@samsung.com,
tomasz.figa@gmail.com, abrestic@chromium.org
Subject: Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers
Date: Mon, 12 Aug 2013 12:34:48 +0100 [thread overview]
Message-ID: <20130812113447.GW6427@sirena.org.uk> (raw)
In-Reply-To: <21180092.af8YMiXtjc@amdc1227>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Mon, Aug 12, 2013 at 01:14:20PM +0200, Tomasz Figa wrote:
> On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote:
> > + i2s_0: i2s@03830000 {
> > + status = "disabled";
> If a node does not require any board-specific properties for the device to
> operate properly, there is no point in disabling it, just to add a single
> status property at board level.
I'd expect that to interact badly with the pinmuxing - unless the device
is disabled it'll try to grab its pins on probe which is not going to be
a good idea unless it is actually wired up for use in the system. Or is
there some other mechanism for handling that?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-12 11:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 10:07 [PATCH V4 0/4] Add i2s nodes on Exynos5420 and enable sound support on sdmk5420 Padmavathi Venna
2013-08-12 10:07 ` [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers Padmavathi Venna
2013-08-12 11:14 ` Tomasz Figa
2013-08-12 11:34 ` Mark Brown [this message]
2013-08-12 11:41 ` Tomasz Figa
2013-08-12 13:12 ` Mark Brown
2013-08-12 17:02 ` Tomasz Figa
2013-08-14 5:51 ` Padma Venkat
2013-08-14 8:19 ` Tomasz Figa
2013-08-12 10:07 ` [PATCH V4 2/4] ARM: dts: Add i2c bus 1 and it's audio codec child node on smdk5420 Padmavathi Venna
2013-08-12 10:07 ` [PATCH V4 3/4] ARM: dts: Add osc clock " Padmavathi Venna
2013-08-12 10:07 ` [PATCH V4 4/4] ARM: dts: Enable sound support " Padmavathi Venna
2013-08-12 11:17 ` Tomasz Figa
2013-08-12 11:18 ` [PATCH V4 0/4] Add i2s nodes on Exynos5420 and enable sound support on sdmk5420 Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812113447.GW6427@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox