From: Dan Carpenter <dan.carpenter@oracle.com>
To: s.nawrocki@samsung.com
Cc: linux-samsung-soc@vger.kernel.org
Subject: re: [media] exynos4-is: Add Exynos5250 SoC support to fimc-lite driver
Date: Wed, 21 Aug 2013 11:52:41 +0300 [thread overview]
Message-ID: <20130821085241.GA7574@elgon.mountain> (raw)
Hello Sylwester Nawrocki,
This is a semi-automatic email about new static checker warnings.
The patch 086eca2905d0: "[media] exynos4-is: Add Exynos5250 SoC
support to fimc-lite driver" from Jun 14, 2013, leads to the
following Smatch complaint:
drivers/media/platform/exynos4-is/fimc-lite.c:1521 fimc_lite_probe()
error: we previously assumed 'dev->of_node' could be null (see line 1511)
drivers/media/platform/exynos4-is/fimc-lite.c
1510
1511 if (dev->of_node) {
^^^^^^^^^^^^
Existing check.
1512 of_id = of_match_node(flite_of_match, dev->of_node);
1513 if (of_id)
1514 drv_data = (struct flite_drvdata *)of_id->data;
1515 fimc->index = of_alias_get_id(dev->of_node, "fimc-lite");
1516 }
1517
1518 if (!drv_data || fimc->index >= drv_data->num_instances ||
1519 fimc->index < 0) {
1520 dev_err(dev, "Wrong %s node alias\n",
1521 dev->of_node->full_name);
^^^^^^^^^^^^^^
Patch adds this dereference.
1522 return -EINVAL;
1523 }
regards,
dan carpenter
next reply other threads:[~2013-08-21 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:52 Dan Carpenter [this message]
2013-08-25 13:30 ` [media] exynos4-is: Add Exynos5250 SoC support to fimc-lite driver Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821085241.GA7574@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox