From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linaro-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250
Date: Thu, 12 Sep 2013 21:00:13 +0100 [thread overview]
Message-ID: <20130912200013.GU29403@sirena.org.uk> (raw)
In-Reply-To: <1657964.f1bIFjAZ98@amdc1227>
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
On Thu, Sep 12, 2013 at 05:55:59PM +0200, Tomasz Figa wrote:
> On Thursday 12 of September 2013 14:52:33 Mark Brown wrote:
> > Please delete unneeded context from your mails, it makes it much easier
> > to find the new content.
> I always snip unnecessary parts of quoted message if its really long, but
> if its length is in acceptable range then I try to keep the whole message
> just for reference.
I tend to say that when I find myself paging through entire screens of
quote and can't see the relevance to any content I eventually find.
> i2c@12CA0000 does look like a normal hardware I2C controller, which needs
> some extra properties like samsung,i2c-sda-delay or samsung,i2c-max-bus-
Shouldn't these have sane defaults?
> freq. However they are specified in cros5250-common.dtsi, so I'd say that
> this might be better place for the status override as well.
Can we rename that file to something like exynos5250-cros-common.dtsi
so that it's obvious it's relevant to exynos? I had completely failed
to notice that it was anything to do with Exynos when I was searching
for affected DTS files.
Especially given that it's included in exactly one DTS at the minute...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-12 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 10:40 [PATCH 1/3] ARM: dts: Disable Exynos5250 I2S controllers by default Mark Brown
2013-09-12 10:40 ` [PATCH 2/3] ARM: dts: Leave Exynos5250 SPI controller disabled " Mark Brown
2013-09-12 11:56 ` Tomasz Figa
2013-09-12 13:50 ` Mark Brown
2013-09-12 15:51 ` Tomasz Figa
2013-09-12 20:00 ` Mark Brown
2013-09-12 10:40 ` [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250 Mark Brown
2013-09-12 12:58 ` Tomasz Figa
2013-09-12 13:52 ` Mark Brown
2013-09-12 15:55 ` Tomasz Figa
2013-09-12 20:00 ` Mark Brown [this message]
[not found] ` <20130912200013.GU29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-12 23:02 ` Tomasz Figa
2013-09-12 23:42 ` Mark Brown
2013-09-12 15:03 ` Stephen Warren
2013-09-12 15:59 ` Tomasz Figa
2013-09-12 11:24 ` [PATCH 1/3] ARM: dts: Disable Exynos5250 I2S controllers by default Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912200013.GU29403@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linaro-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox