From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH 06/10] ARM: shmobile: Initialize PWM backlight enable_gpio field Date: Wed, 25 Sep 2013 14:40:00 +0900 Message-ID: <20130925053957.GF1916@verge.net.au> References: <1379972467-11243-1-git-send-email-treding@nvidia.com> <1379972467-11243-7-git-send-email-treding@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1379972467-11243-7-git-send-email-treding@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Tony Lindgren , Eric Miao , Haojian Zhuang , Ben Dooks , Kukjin Kim , Magnus Damm , Guan Xuetao , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, openezx-devel@lists.openezx.org, linux-samsung-soc@vger.kernel.org, linux-sh@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On Mon, Sep 23, 2013 at 11:41:03PM +0200, Thierry Reding wrote: > The GPIO API defines 0 as being a valid GPIO number, so this field needs > to be initialized explicitly. > > Signed-off-by: Thierry Reding > --- > arch/arm/mach-shmobile/board-armadillo800eva.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c > index 7f8f607..6ccb854 100644 > --- a/arch/arm/mach-shmobile/board-armadillo800eva.c > +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c > @@ -423,6 +423,7 @@ static struct platform_pwm_backlight_data pwm_backlight_data = { > .max_brightness = 255, > .dft_brightness = 255, > .pwm_period_ns = 33333, /* 30kHz */ > + .enable_gpio = -1, > }; > > static struct platform_device pwm_backlight_device = { Acked-by: Simon Horman