Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
	Sangbeom Kim <sbkim73@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 2/3] ASoC: dmaengine: Support custom channel names
Date: Wed, 23 Oct 2013 12:30:28 +0100	[thread overview]
Message-ID: <20131023113028.GP9388@sirena.org.uk> (raw)
In-Reply-To: <5266654D.30200@metafoo.de>


[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]

On Tue, Oct 22, 2013 at 01:45:17PM +0200, Lars-Peter Clausen wrote:
> On 10/19/2013 06:43 PM, Mark Brown wrote:

> > Some devices have more than just simple TX and RX DMA channels, for example
> > modern Samsung I2S IPs support a secondary transmit DMA stream which is
> > mixed into the primary stream during playback. Allow such devices to
> > specify the names of the channels to be requested in their dma_data.

> As shortly discussed yesterday, I think the general idea is fine. But it
> might be better to have the names available at PCM creation time, since this
> allows us to e.g. do proper probe referral and will also have the code take
> the same path in the DT case, no matter if it uses the default names or not.

I agree, but I'm thinking that the way to do this is to get the entire
struct provided earlier so that the compat drivers get to use this stuff
too.  Is there any great reason not to do that?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2013-10-23 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-19 16:43 [PATCH 1/3] ASoC: samsung: Provide helper for DMA init Mark Brown
2013-10-19 16:43 ` [PATCH 2/3] ASoC: dmaengine: Support custom channel names Mark Brown
2013-10-22 11:45   ` [alsa-devel] " Lars-Peter Clausen
2013-10-23 11:30     ` Mark Brown [this message]
2013-10-23 13:32       ` Lars-Peter Clausen
2013-10-19 16:43 ` [PATCH 3/3] ASoC: samsung: Use ASoC dmaengine code where possible Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131023113028.GP9388@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=kgene.kim@samsung.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox