From: Mark Brown <broonie@kernel.org>
To: Rajeshwari Birje <rajeshwari.birje@gmail.com>
Cc: Tomasz Figa <t.figa@samsung.com>,
Rajeshwari S Shinde <rajeshwari.s@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-spi@vger.kernel.org, Simon Glass <sjg@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Doug Anderson <dianders@google.com>
Subject: Re: [PATCH V4] spi: s3c64xx: Enable Word transfer
Date: Wed, 6 Nov 2013 08:21:41 +0000 [thread overview]
Message-ID: <20131106082141.GA11602@sirena.org.uk> (raw)
In-Reply-To: <CAPs=JDcHVe4q7R-3f3SBu8g=Ebkz57AbPN8e2jspVTGYnZ1vqA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Wed, Nov 06, 2013 at 10:23:07AM +0530, Rajeshwari Birje wrote:
> On Thu, Oct 31, 2013 at 6:07 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> > The driver as of today's linux-next does not seem to support word
> > transfers. Do you have some additional, out of tree patches that add
> > such support?
> Yes I set the bits_per_word to 32/16 in drivers/mtd/devices/m25p80.c
> m25p_probe function and the call spi_setup(spi).
This sound wrong. If you just set bits per word then this should result
in data corruption on the bus since it should cause the words written to
the bus to be reordered. Are you sure that the existing driver isn't
working correctly?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-06 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 5:32 [PATCH V4] spi: s3c64xx: Enable Word transfer Rajeshwari S Shinde
[not found] ` <1382074356-28430-1-git-send-email-rajeshwari.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-19 16:25 ` Mark Brown
[not found] ` <CAPnjgZ1A335KstnpTRwpxEbBArtqh1sYSPQJBw6LX5zUeptpfA@mail.gmail.com>
2013-10-19 20:04 ` Mark Brown
2013-10-29 10:59 ` Rajeshwari Birje
[not found] ` <CAPs=JDeOqkJT32quBH1tF9FtFUOt=CHP7m6ZqzhfASM2uPj-dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-29 11:29 ` Rajeshwari Birje
[not found] ` <CAPs=JDdzvnM5BzgRLhLsJrdwcVSwxd6x8_kFz0EvB=OjFfVszw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-29 16:39 ` Mark Brown
[not found] ` <20131029163926.GA6776-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-10-30 6:22 ` Rajeshwari Birje
[not found] ` <CAPs=JDeDbevjOtMH0y+9aVSbNSV4zmEQxWygtB-f69XzooSinQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-30 17:00 ` Mark Brown
2013-10-30 17:06 ` Tomasz Figa
2013-10-31 10:47 ` Rajeshwari Birje
2013-10-31 12:37 ` Tomasz Figa
2013-11-06 4:53 ` Rajeshwari Birje
2013-11-06 8:21 ` Mark Brown [this message]
[not found] ` <20131106082141.GA11602-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-07 9:22 ` Rajeshwari Birje
[not found] ` <CAPs=JDctq1yRbuwnFH40dnQJJHF0C_D1p3iVokSPusPXA27Qeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-07 9:39 ` Tomasz Figa
2013-11-07 9:59 ` Lukasz Czerwinski
2013-11-08 11:05 ` Mark Brown
2013-11-10 17:26 ` Tomasz Figa
2013-11-13 8:28 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106082141.GA11602@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=dianders@google.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rajeshwari.birje@gmail.com \
--cc=rajeshwari.s@samsung.com \
--cc=sjg@chromium.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox