Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: Tomasz Figa <t.figa@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kgene Kim <kgene.kim@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: Boot hang on Origen with (!SMP && CPU_IDLE)
Date: Fri, 3 Jan 2014 14:37:10 +0100	[thread overview]
Message-ID: <201401031437.10624.arnd@arndb.de> (raw)
In-Reply-To: <CAHbNUh1LF9+v1en==t8znAL518ERWE2LffTDykAEb2HST+WKTw@mail.gmail.com>

On Friday 03 January 2014, Tushar Behera wrote:
> Hi,
> 
> We are getting boot-time system hang on Exynos4210-based Origen board
> if the kernel (right now testing v3.13-rc6) is built using
> exynos_defconfig, disabling SMP support and enabling CPU_IDLE support.
> The boot log can be found here[1].
> 
> Git bisect points to following commit.
> 
> commit 87107d89052bcec1fe91b309631de4ed294a5171
> Author: Arnd Bergmann <arnd@arndb.de>
> Date:   Wed Jun 19 01:36:52 2013 +0900
> 
>     ARM: EXYNOS: Remove legacy L2X0 initialization
> 
>     Since Exynos is now supporting only DT-based boot, the old L2X0
>     initialization code is not needed anymore, so exynos4_l2x0_cache_init()
>     can be greatly simplified.
> 
>     Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>     Signed-off-by: Tomasz Figa <t.figa@samsung.com>
>     Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>     Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> Reverting the changes, the kernel boots up.
> 
> Any idea what else we might be missing?
> 
> [1] http://pastebin.com/0mP6ML4y

Hmm, the boot log contains no message about the l2 cache controller getting
initialized, which means that l2x0_of_init probably failed before calling
l2x0_init. It also seems that the dts files distributed with the kernel
are lacking nodes for the l2x0 device, which is indeed a perfectly good
explanation although it doesn't explain at all why it ever worked on
any system with my patch.

Can you check if there is a correct cache controller node in your device
tree, and whether it works when you add one? If so, we should probably
add a couple of stable backport patches to the dts files. It would also
be a good time to get rid of the L2_AUX_VAL and L2_AUX_MASK defines and
just read the respective settings from DT.

	Arnd

  reply	other threads:[~2014-01-03 13:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03 11:49 Boot hang on Origen with (!SMP && CPU_IDLE) Tushar Behera
2014-01-03 13:37 ` Arnd Bergmann [this message]
2014-01-03 13:58   ` Tomasz Figa
2014-01-06 10:31     ` Tushar Behera
2014-01-06 15:30       ` Arnd Bergmann
2014-01-06 16:41         ` Tomasz Figa
2014-01-07  7:03           ` Tushar Behera
2014-01-07  8:51             ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401031437.10624.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=t.figa@samsung.com \
    --cc=tushar.behera@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox