From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 08/14] mfd: sec: Add support for S2MPS14 Date: Wed, 12 Feb 2014 15:46:38 +0000 Message-ID: <20140212154638.GA20026@lee--X1> References: <1392123837-5517-1-git-send-email-k.kozlowski@samsung.com> <1392123837-5517-9-git-send-email-k.kozlowski@samsung.com> <20140212091724.GS15081@lee--X1> <1392199417.22265.12.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-we0-f176.google.com ([74.125.82.176]:36395 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbaBLPrj (ORCPT ); Wed, 12 Feb 2014 10:47:39 -0500 Received: by mail-we0-f176.google.com with SMTP id q58so6004137wes.7 for ; Wed, 12 Feb 2014 07:47:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <1392199417.22265.12.camel@AMDC1943> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: Sangbeom Kim , Samuel Ortiz , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz > > > Add support for S2MPS14 PMIC device to the MFD sec-core driver. > > > The S2MPS14 is similar to S2MPS11 but it has fewer regulators, tw= o > > > clocks instead of three and a little different registers layout. > > >=20 > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > drivers/mfd/sec-core.c | 48 +++++++++-- > > > drivers/mfd/sec-irq.c | 89 +++++++++++++++++++- > > > include/linux/mfd/samsung/core.h | 1 + > > > include/linux/mfd/samsung/irq.h | 27 +++++++ > > > include/linux/mfd/samsung/rtc.h | 56 +++++++++++-- > > > include/linux/mfd/samsung/s2mps14.h | 152 +++++++++++++++++++++= ++++++++++++++ > > > 6 files changed, 361 insertions(+), 12 deletions(-) > > > create mode 100644 include/linux/mfd/samsung/s2mps14.h > > >=20 > > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > >=20 > > > >=20 > > > +static const struct mfd_cell s2mps14_devs[] =3D { > > > + { > > > + .name =3D "s2mps14-pmic", > > > + }, { > > > + .name =3D "s2mps14-rtc", > > > + }, { > > > + .name =3D "s2mps14-clk", > > > + } > > > +}; > >=20 > > No device tree support for the children? >=20 > There aren't any compatibles also for other devices (s2mps11, s5m876X= ) > so I didn't want to introduce different behavior for S2MPS14. If you > want of_compatible here then it should be added for all devices. =46air enough. > > > >=20 > > > +#define S2MPS14_LDO_VSEL_MASK 0x3F > > > +#define S2MPS14_BUCK_VSEL_MASK 0xFF > > > +#define S2MPS14_ENABLE_MASK (0x03 << S2MPS14_ENABLE_SHIFT) > > > +#define S2MPS14_ENABLE_SHIFT 6 > > > +#define S2MPS14_LDO_N_VOLTAGES (S2MPS14_LDO_VSEL_MASK + 1) > > > +#define S2MPS14_BUCK_N_VOLTAGES (S2MPS14_BUCK_VSEL_MASK + 1) > >=20 > > Nit: Can you line these up using tabs please? When you submit, please add my: Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog