Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

Mark Brown
2014-02-14T20:59:15Z

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Fri, Feb 14, 2014 at 09:15:12AM +0100, Krzysztof Kozlowski wrote:

> My initial idea was to do this similarly to the S5M8767 regulator (where
> there is also 4th mode: low power). The presence of GPIO in DTS can
> simplify the bindings but on the other hand it wouldn't be compatible
> with S5M8767 regulator driver. This may complicate the merge of these
> drivers.

They can always use separate ops.

> What is your opinion on this - should I abandon the "op_mode" idea and
> use presence of GPIO?

Yes, that's better - especially since the framework has support for
enable GPIOs. It can do things like handle cases where the hardware has
tied the enables for several regulators together so they all need to be
enabled and disabled as one.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]