From: Mark Brown <broonie@kernel.org>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
spi-devel-general@lists.sourceforge.net,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
grant.likely@secretlab.ca, jaswinder.singh@linaro.org,
Kukjin Kim <kgene.kim@samsung.com>,
cpgs@samsung.com, devicetree@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Tomasz Figa <t.figa@samsung.com>
Subject: Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"
Date: Wed, 11 Jun 2014 19:27:13 +0100 [thread overview]
Message-ID: <20140611182713.GM5099@sirena.org.uk> (raw)
In-Reply-To: <CAHfPSqB3V+vBCj03WLkeLQ5e7O4r+pUKQ-yZpK=tdAqVV1GuLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Wed, Jun 11, 2014 at 11:53:30PM +0530, Naveen Krishna Ch wrote:
> On 11 June 2014 23:20, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> > - in DT case, don't do anything in the driver about the GPIO chip
> > select, because it will be handled automatically by the core.
> But, i see that gpio_request_one is needed in _setup function in the driver.
> Except that no other gpio related operation is needed in the driver.
Ideally this code could be moved into the core too - indeed, ideally the
non-DT case could be handled by the core too except for the bit where we
look up what GPIO to use.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-11 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 6:31 [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio" Naveen Krishna Chatradhi
2014-06-11 6:31 ` [PATCH 2/2 v3] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node Naveen Krishna Chatradhi
2014-06-11 11:21 ` Javier Martinez Canillas
2014-06-11 11:29 ` Naveen Krishna Ch
2014-06-11 11:13 ` [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio" Javier Martinez Canillas
2014-06-11 11:38 ` Naveen Krishna Ch
2014-06-11 17:27 ` Javier Martinez Canillas
2014-06-11 17:50 ` Tomasz Figa
2014-06-11 18:18 ` Javier Martinez Canillas
2014-06-11 18:23 ` Naveen Krishna Ch
2014-06-11 18:27 ` Mark Brown [this message]
2014-06-11 18:28 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611182713.GM5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=grant.likely@secretlab.ca \
--cc=jaswinder.singh@linaro.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox