From: Guenter Roeck <linux@roeck-us.net>
To: Tomasz Figa <t.figa@samsung.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Wim Van Sebroeck" <wim@iguana.be>,
linux-samsung-soc@vger.kernel.org,
"Mike Turquette" <mturquette@linaro.org>
Subject: Re: [RFC PATCH 2/3] clk: samsung: register restart notifiers for s3c2412 and s3c2443
Date: Tue, 8 Jul 2014 09:23:18 -0700 [thread overview]
Message-ID: <20140708162318.GB9157@roeck-us.net> (raw)
In-Reply-To: <53BBFF22.10904@samsung.com>
On Tue, Jul 08, 2014 at 04:24:34PM +0200, Tomasz Figa wrote:
> Hi Heiko,
>
> On 06.07.2014 20:43, Heiko Stübner wrote:
> > S3C2412, S3C2443 and their derivatives contain a special software-reset
> > register in their system-controller.
> >
> > Therefore register a restart-notifier for those.
>
> I wonder if we really need to differentiate between these SoCs instead
> of just using the watchdog reset for all of them. If there is no reason
> to prefer software reset, then some code could be removed and things
> would be more unified.
>
Depends if the other method is always available. If not, it might make sense
to register this handler with lower priority to have a fallback.
Guenter
next prev parent reply other threads:[~2014-07-08 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 18:42 [RFC PATCH 0/3] ARM: restart-notifier support for some architectures Heiko Stübner
2014-07-06 18:42 ` [RFC PATCH 1/3] watchdog: s3c2410: add restart notifier Heiko Stübner
2014-07-08 14:21 ` Tomasz Figa
2014-07-08 16:21 ` Guenter Roeck
2014-07-06 18:43 ` [RFC PATCH 2/3] clk: samsung: register restart notifiers for s3c2412 and s3c2443 Heiko Stübner
2014-07-08 14:24 ` Tomasz Figa
2014-07-08 16:23 ` Guenter Roeck [this message]
2014-07-06 18:43 ` [RFC PATCH 3/3] clk: rockchip: add restart notifier Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708162318.GB9157@roeck-us.net \
--to=linux@roeck-us.net \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=t.figa@samsung.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox