From: Thierry Reding <thierry.reding@gmail.com>
To: Ajay Kumar <ajaykumar.rs@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, seanpaul@google.com,
daniel.vetter@ffwll.ch, joshi@samsung.com,
dri-devel@lists.freedesktop.org, ajaynumb@gmail.com,
javier@dowhile0.org, prashanth.g@samsung.com
Subject: Re: [RESEND PATCH V5 03/12] drm/exynos: dp: modify driver to support drm_panel
Date: Mon, 21 Jul 2014 10:02:29 +0200 [thread overview]
Message-ID: <20140721080216.GD8843@ulmo> (raw)
In-Reply-To: <1405629839-12086-4-git-send-email-ajaykumar.rs@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 977 bytes --]
On Fri, Jul 18, 2014 at 02:13:49AM +0530, Ajay Kumar wrote:
[...]
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
[...]
> depends on DRM_EXYNOS_FIMD && ARCH_EXYNOS && (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
One of the reasons the current way of implementing bridges is that it
doesn't scale, as shown by this ridiculous dependency. In patch
[RESEND PATCH V5 12/12] drm/exynos: Add ps8622 lvds bridge discovery to DP driver
you add support for another type of bridge but it doesn't update this
dependency. I suspect that in order for this to work properly you'll
need to extend the dependency like so (rewritten to make it somewhat
cleaner):
depends on DRM_EXYNOS_FIMD && ARCH_EXYNOS
depends on DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS
depends on DRM_PS8622=n || DRM_PS8622=y || DRM_PS8622=DRM_EXYNOS
And you'll need one more of these lines for each new bridge chip that
you want to support.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-07-21 8:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 20:43 [PATCH V5 00/12] drm/exynos: few patches to enhance bridge chip support Ajay Kumar
2014-07-17 20:43 ` [RESEND PATCH V5 01/12] drm/exynos: Move DP setup out of hotplug workqueue Ajay Kumar
2014-07-22 14:59 ` Sean Paul
2014-07-23 11:22 ` Ajay kumar
2014-07-23 14:42 ` Sean Paul
2014-07-23 15:18 ` Ajay kumar
2014-07-24 20:16 ` Sean Paul
2014-07-17 20:43 ` [RESEND PATCH V5 02/12] drm/panel: add prepare and unprepare routines Ajay Kumar
2014-07-17 20:43 ` [RESEND PATCH V5 03/12] drm/exynos: dp: modify driver to support drm_panel Ajay Kumar
2014-07-21 8:02 ` Thierry Reding [this message]
2014-07-21 8:14 ` Thierry Reding
2014-07-21 12:18 ` Ajay kumar
2014-07-17 20:43 ` [PATCH V5 04/12] drm/panel: Add driver for lvds/edp based panels Ajay Kumar
2014-07-17 20:43 ` [PATCH V5 05/12] Documentation: Add DT bindings for panel-lvds driver Ajay Kumar
2014-07-17 20:50 ` Ajay kumar
2014-07-17 22:48 ` Thierry Reding
2014-07-18 6:48 ` Ajay kumar
2014-07-21 7:52 ` Thierry Reding
2014-07-21 12:30 ` Ajay kumar
2014-07-17 20:43 ` [RESEND PATCH V5 06/12] drm/bridge: add helper functions to support bridge chain Ajay Kumar
2014-07-17 20:43 ` [PATCH V5 07/12] drm/bridge: Add a driver which binds drm_bridge with drm_panel Ajay Kumar
2014-07-17 20:43 ` [RESEND PATCH V5 08/12] drm/bridge: ptn3460: Support bridge chaining Ajay Kumar
2014-07-21 7:55 ` Inki Dae
2014-07-21 8:22 ` Thierry Reding
2014-07-21 11:58 ` Ajay kumar
2014-07-21 12:40 ` Thierry Reding
2014-07-22 6:21 ` Ajay kumar
2014-07-17 20:43 ` [RESEND PATCH V5 09/12] drm/exynos: dp: create bridge chain using ptn3460 and panel_binder Ajay Kumar
2014-07-17 20:43 ` [PATCH V5 10/12] drm/bridge: Add ps8622/ps8625 bridge driver Ajay Kumar
2014-07-17 20:43 ` [PATCH V5 11/12] Documentation: Add DT bindings for " Ajay Kumar
2014-07-17 20:51 ` Ajay kumar
2014-07-21 7:06 ` Thierry Reding
2014-07-21 10:54 ` Ajay kumar
2014-07-17 20:43 ` [RESEND PATCH V5 12/12] drm/exynos: Add ps8622 lvds bridge discovery to DP driver Ajay Kumar
2014-07-21 7:10 ` Thierry Reding
2014-07-21 11:28 ` Ajay kumar
2014-07-21 12:54 ` Thierry Reding
2014-07-21 14:36 ` Ajay kumar
2014-07-21 14:44 ` Thierry Reding
2014-07-22 6:05 ` Ajay kumar
2014-07-22 7:51 ` Thierry Reding
2014-07-21 7:51 ` [PATCH V5 00/12] drm/exynos: few patches to enhance bridge chip support Inki Dae
2014-07-21 11:33 ` Ajay kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721080216.GD8843@ulmo \
--to=thierry.reding@gmail.com \
--cc=ajaykumar.rs@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javier@dowhile0.org \
--cc=joshi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prashanth.g@samsung.com \
--cc=seanpaul@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox