From: Mark Brown <broonie@kernel.org>
To: Padmavathi Venna <padma.kvr@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller
Date: Thu, 6 Nov 2014 10:26:36 +0000 [thread overview]
Message-ID: <20141106102636.GT8509@sirena.org.uk> (raw)
In-Reply-To: <1415267509-16653-1-git-send-email-padma.v@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Thu, Nov 06, 2014 at 03:21:49PM +0530, Padmavathi Venna wrote:
> Exynos7 SPI controller supports only the auto Selection of
> CS toggle mode and Exynos7 SoC includes six SPI controllers.
> Add support for these changes in Exynos7 SPI controller driver.
Could you give a bit more detail on what the "auto selection of CS
toggle mode" is - in the diff it looks like it's not an existing mode.
I'm a bit worried that it's not going to function well with devices that
send more than one transfer per message.
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
It's better if your signoff is using the same e-maill address as
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-06 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 9:51 [PATCH] spi: s3c64xx: add support for exynos7 SPI controller Padmavathi Venna
2014-11-06 10:26 ` Mark Brown [this message]
[not found] ` <20141106102636.GT8509-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-07 8:31 ` Padma Venkat
2014-11-07 10:13 ` Mark Brown
2014-11-10 4:50 ` Padma Venkat
[not found] ` <CAAgF-Bd=S7-PoA7GZoy87W9Dem3OXVhc1tL-eyWEAHvF0LPTKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-14 11:16 ` Padma Venkat
[not found] ` <CAAgF-BcARoRZv=BPqQWyp6rJQQ=CE0FEUz_2vgQSpeZyLwbkBw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 7:08 ` Padma Venkat
2014-11-25 3:07 ` Padma Venkat
[not found] ` <1415267509-16653-1-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-26 19:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106102636.GT8509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=padma.kvr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox