Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Robert Baldyga <r.baldyga@samsung.com>,
	Paul Zimmerman <paulz@synopsys.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v5] usb: dwc2/gadget: rework disconnect event handling
Date: Thu, 20 Nov 2014 13:53:17 -0600	[thread overview]
Message-ID: <20141120195317.GG23217@saruman> (raw)
In-Reply-To: <1416214782-13911-1-git-send-email-m.szyprowski@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Mon, Nov 17, 2014 at 09:59:42AM +0100, Marek Szyprowski wrote:
> This patch adds a call to s3c_hsotg_disconnect() from 'end session'
> interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem
> about unplugged usb cable. DISCONNINT interrupt cannot be used for this
> purpose, because it is asserted only in host mode.
> 
> To avoid reporting disconnect event more than once, a disconnect call has
> been moved from USB_REQ_SET_ADDRESS handling function to SESSREQINT
> interrupt. This way driver ensures that disconnect event is reported
> either when usb cable is unplugged or every time the host starts a new
> session. To handle devices which has been synthesized without
> SRP support, connected state is set in ENUMDONE interrupt.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

doesn't apply, please rebase on my testing/next:

checking file drivers/usb/dwc2/core.h
Hunk #1 FAILED at 210.
1 out of 1 hunk FAILED
checking file drivers/usb/dwc2/gadget.c
Hunk #1 FAILED at 1029.
Hunk #2 succeeded at 1108 (offset 1 line).
Hunk #3 succeeded at 2031 (offset 1 line).
Hunk #4 FAILED at 2293.
2 out of 4 hunks FAILED

thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-11-20 19:53 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 10:45 [PATCH v2 00/10] more dwc2/gadget fixes Marek Szyprowski
2014-10-20 10:45 ` [PATCH v2 01/10] usb: dwc2/gadget: report disconnect event from 'end session' irq Marek Szyprowski
     [not found]   ` <1413801940-31086-2-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-25  1:23     ` Paul Zimmerman
     [not found]       ` <A2CA0424C0A6F04399FB9E1CD98E0304844E5C19-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2014-10-31  7:45         ` Marek Szyprowski
2014-10-31  8:04   ` [PATCH v3] " Marek Szyprowski
2014-10-31 18:15     ` Paul Zimmerman
2014-11-13 13:39       ` Marek Szyprowski
     [not found]         ` <5464B496.9010000-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-13 20:50           ` Paul Zimmerman
2014-11-14 10:31             ` Marek Szyprowski
2014-11-14 12:00             ` Marek Szyprowski
     [not found]               ` <5465EEF3.7060902-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-14 12:20                 ` [PATCH v4] usb: dwc2/gadget: rework disconnect event handling Marek Szyprowski
     [not found]                   ` <1415967607-6174-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-14 19:01                     ` Paul Zimmerman
2014-11-14 19:04                       ` Felipe Balbi
2014-11-14 21:21                         ` Paul Zimmerman
2014-11-14 22:09                         ` Paul Zimmerman
2014-11-17  6:27                           ` Marek Szyprowski
2014-11-17  8:59                             ` [PATCH v5] " Marek Szyprowski
     [not found]                               ` <1416214782-13911-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-18 20:56                                 ` Paul Zimmerman
2014-11-20 19:53                               ` Felipe Balbi [this message]
2014-10-20 10:45 ` [PATCH v2 05/10] usb: dwc2/gadget: move setting last reset time to s3c_hsotg_core_init Marek Szyprowski
     [not found]   ` <1413801940-31086-6-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-25  0:23     ` Paul Zimmerman
     [not found] ` <1413801940-31086-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-20 10:45   ` [PATCH v2 02/10] usb: dwc2/gadget: fix enumeration issues Marek Szyprowski
     [not found]     ` <1413801940-31086-3-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-25  0:21       ` Paul Zimmerman
2014-10-20 10:45   ` [PATCH v2 03/10] usb: dwc2/gadget: fix gadget unregistration in udc_stop() function Marek Szyprowski
     [not found]     ` <1413801940-31086-4-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-23 15:01       ` Felipe Balbi
2014-10-23 18:18         ` Paul Zimmerman
     [not found]           ` <A2CA0424C0A6F04399FB9E1CD98E0304844E5483-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2014-10-23 18:56             ` Felipe Balbi
2014-10-20 10:45   ` [PATCH v2 04/10] usb: dwc2/gadget: disable phy before turning off power regulators Marek Szyprowski
     [not found]     ` <1413801940-31086-5-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-23 15:01       ` Felipe Balbi
2014-10-23 18:15         ` Paul Zimmerman
2014-10-23 18:58           ` Felipe Balbi
2014-10-20 10:45   ` [PATCH v2 06/10] usb: dwc2/gadget: decouple setting soft-disconnect from s3c_hsotg_core_init Marek Szyprowski
2014-10-25  0:35     ` Paul Zimmerman
2014-10-27 13:52       ` Marek Szyprowski
2014-10-20 10:45   ` [PATCH v2 09/10] usb: dwc2/gadget: fix calls to phy control functions in suspend/resume code Marek Szyprowski
2014-10-25  0:45     ` Paul Zimmerman
2014-10-20 10:45   ` [PATCH v2 10/10] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state Marek Szyprowski
2014-10-25  1:16     ` Paul Zimmerman
2014-10-27  7:18       ` Marek Szyprowski
2014-10-31 10:08         ` Marek Szyprowski
2014-10-31 10:12           ` [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls Marek Szyprowski
2014-10-31 10:12             ` [PATCH v3 2/2] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state Marek Szyprowski
2014-10-31 18:46             ` [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls Paul Zimmerman
     [not found]               ` <A2CA0424C0A6F04399FB9E1CD98E0304844E7FDD-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2014-11-13 15:17                 ` Marek Szyprowski
2014-11-13 20:55                   ` Paul Zimmerman
2014-11-14  9:19                     ` Marek Szyprowski
2014-11-14 19:43                       ` Paul Zimmerman
2014-11-14 19:51                         ` Felipe Balbi
     [not found]             ` <1414750354-19571-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-18 21:00               ` Paul Zimmerman
2014-11-20 19:53             ` Felipe Balbi
2014-10-20 10:45 ` [PATCH v2 07/10] usb: dwc2/gadget: move phy control calls out of pullup() method Marek Szyprowski
2014-10-25  0:36   ` Paul Zimmerman
2014-10-20 10:45 ` [PATCH v2 08/10] usb: dwc2/gadget: use soft-disconnect udc feature in " Marek Szyprowski
2014-10-25  0:43   ` Paul Zimmerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141120195317.GG23217@saruman \
    --to=balbi@ti.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=paulz@synopsys.com \
    --cc=r.baldyga@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox