From: Mark Brown <broonie@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc@vger.kernel.org, padma.v@samsung.com,
sbkim73@samsung.com, drake@endlessm.com, kgene@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 06/16] ASoC: samsung: i2s: Move clk enable to the platform driver probe()
Date: Tue, 6 Jan 2015 18:06:19 +0000 [thread overview]
Message-ID: <20150106180619.GN2634@sirena.org.uk> (raw)
In-Reply-To: <1418997336-17777-7-git-send-email-s.nawrocki@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1107 bytes --]
On Fri, Dec 19, 2014 at 02:55:26PM +0100, Sylwester Nawrocki wrote:
> Gating the I2S bus clock in the driver's runtime PM callbacks has
> currently really no effect since the clock is being enabled
> in the DAI's probe() and thus is permanently turned on. Now we just
> move the enable to the platform driver's probe(), which doesn't
> change the situation much. It will allow us to register a clock
> provider already in samsung_i2s_probe() function.
That doesn't sound quite right - the normal idiom for this stuff is to
enable on probe, mark the device as active then if runtime PM is enabled
it can idle the device and turn off the clock. That way if runtime PM
is disabled things continue to run. I've not checked to see if this is
actually happening correctly all the way through but that's what's
supposed to happen and means that enabling in the probe should still
result in working clock management.
It will as things currently stand be broken for the dual DAI case so
this is a fix for that (the dual DAI case will double enable if both
links are in use) but the analysis isn't quite correct.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-01-06 18:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 13:55 [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 01/16] ASoC: samsung: i2s: Remove unused gpios field from struct i2s Sylwester Nawrocki
2015-01-06 18:13 ` Mark Brown
2014-12-19 13:55 ` [PATCH v2 02/16] ASoC: samsung: i2s: samsung_i2s_get_driver_data() cleanup Sylwester Nawrocki
[not found] ` <1418997336-17777-3-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-06 18:14 ` Mark Brown
2015-01-14 11:52 ` Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 03/16] ASoC: samsung: i2s: Add return value checks in probe() Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 04/16] ASoC: samsung: i2s: Request memory region in driver probe() Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 05/16] ASoC: samsung: i2s: Move clk_get() to platform " Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 06/16] ASoC: samsung: i2s: Move clk enable to the " Sylwester Nawrocki
2015-01-06 18:06 ` Mark Brown [this message]
2015-01-14 11:56 ` Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 07/16] ASoC: samsung: i2s: Add get_other_dai helper function Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 08/16] ASoC: samsung: i2s: Remove an unneeded goto usage Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 09/16] ASoC: samsung: i2s: Add spinlock in place of local_irq_* calls Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 10/16] ASoC: samsung: i2s: Protect more registers with a spinlock Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 11/16] ASoC: samsung: odroidx2: Handle I2S CDCLK clock conditionally Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 12/16] ASoC: samsung: i2s: Add clk provider DT binding documentation Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 13/16] ASoC: samsung: i2s: Add clock provider for the I2S internal clocks Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 14/16] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 15/16] ARM: dts: Switch Odroid X2/U2 to simple-audio-card Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 16/16] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs Sylwester Nawrocki
2015-01-06 18:15 ` Mark Brown
2015-01-14 11:57 ` Sylwester Nawrocki
2015-01-06 18:17 ` [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks Mark Brown
2015-01-24 1:53 ` Tobias Jakobi
[not found] ` <54C2FB25.4030501-hi6Y0CQ0nG0@public.gmane.org>
2015-01-27 10:59 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106180619.GN2634@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=drake@endlessm.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.v@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox