Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: liquid.acid@gmx.net,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: drm/exynos: Add atomic modesetting support
Date: Tue, 19 May 2015 15:43:00 -0300	[thread overview]
Message-ID: <20150519184300.GA12704@joana> (raw)
In-Reply-To: <933513a3ff2090c9ec2921e8cb71effb@math.uni-bielefeld.de>

Hi Tobias,

2015-05-19 Tobias Jakobi <tjakobi@math.uni-bielefeld.de>:

> OK,
> 
> so Daniel helped me track down this issue. It came from an incorrect
> 'clock-frequency' entry in my DTS. The freq was 500000. Daniel recommended
> 70600000 which works 'fine' (and according to modetest produces a 59Hz
> mode). I say 'fine' because I can't confirm that FIMD is actually working. I
> just see that with that change I no longer get any div-by-zeros in the
> kernel.

That is good to hear! So maybe we are now ready to have the atomic
modesetting patches merged in. I'll send a new version with the last
fix to avoid crashes with null CRTC.

> 
> So fimd_calc_clkdiv needs some sanitizing for 'ideal_clk' at least.
> 
> What still bothers me though is the fact that FIMD actually gets enabled.
> I'm just calling 'modetest -M exynos', so it's just doing probing. Why does
> that trigger dpms?

That comes from restore_fbdev_mode() when modetest closes the file
descriptor, but I'm not sure why a update happens at this time.

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-05-19 18:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 11:44 drm/exynos: Add atomic modesetting support Tobias Jakobi
2015-05-18 19:51 ` Gustavo Padovan
2015-05-18 20:35   ` Daniel Stone
2015-05-18 21:02     ` Gustavo Padovan
2015-05-19 13:53       ` Tobias Jakobi
2015-05-19 14:06         ` Daniel Stone
2015-05-19 14:52           ` Tobias Jakobi
2015-05-19 17:27           ` Tobias Jakobi
2015-05-19 18:43             ` Gustavo Padovan [this message]
2015-05-19 18:54               ` Daniel Stone
  -- strict thread matches above, loose matches on Subject: below --
2015-05-15 10:16 Tobias Jakobi
2015-04-30 21:50 Gustavo Padovan
2015-05-06 21:45 ` Gustavo Padovan
2015-05-07  2:45   ` Inki Dae
2015-05-08 21:45     ` Gustavo Padovan
2015-05-08 21:51 ` Tobias Jakobi
2015-05-09 10:23   ` Inki Dae
2015-05-09 12:13     ` Tobias Jakobi
2015-05-09 12:20       ` Tobias Jakobi
2015-05-09 12:30         ` Tobias Jakobi
2015-05-10 13:54       ` Inki Dae
2015-05-12 18:29         ` Gustavo Padovan
2015-05-14 18:41           ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519184300.GA12704@joana \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liquid.acid@gmx.net \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox