public inbox for linux-samsung-soc@vger.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: tjakobi@math.uni-bielefeld.de, linux-samsung-soc@vger.kernel.org,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v6 02/12] drm/exynos: atomic phase 1: use drm_plane_helper_disable()
Date: Fri, 22 May 2015 12:29:45 -0300	[thread overview]
Message-ID: <20150522152945.GD14089@joana> (raw)
In-Reply-To: <555EA66F.7040702@samsung.com>

Hi Joonyoung,

2015-05-22 Joonyoung Shim <jy0922.shim@samsung.com>:

> On 05/22/2015 05:02 AM, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > The atomic helper to disable planes also uses the optional
> > .atomic_disable() helper. The unique operation it does is calling
> > .win_disable()
> > 
> > exynos_drm_fb_get_buf_cnt() needs a fb check too to avoid a null pointer.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_fb.c    |  2 +-
> >  drivers/gpu/drm/exynos/exynos_drm_plane.c | 29 ++++++++++++++++-------------
> >  2 files changed, 17 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> > index 142eb4e..bf814c8 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> > @@ -136,7 +136,7 @@ unsigned int exynos_drm_fb_get_buf_cnt(struct drm_framebuffer *fb)
> >  
> >  	exynos_fb = to_exynos_fb(fb);
> >  
> > -	return exynos_fb->buf_cnt;
> > +	return exynos_fb ? exynos_fb->buf_cnt : 0;
> 
> I think this should be checked by exynos_check_plane on plane disabling
> routine whether fb is NULL or not.

Yeah, this makes more sense. I fixed this and checkpatch error.

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-05-22 15:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 20:02 [PATCH v6 00/12] drm/exynos: atomic modesetting support Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 01/12] drm/exynos: atomic phase 1: use drm_plane_helper_update() Gustavo Padovan
2015-05-22  3:45   ` Joonyoung Shim
2015-05-22 15:27     ` Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 02/12] drm/exynos: atomic phase 1: use drm_plane_helper_disable() Gustavo Padovan
2015-05-22  3:45   ` Joonyoung Shim
2015-05-22 15:29     ` Gustavo Padovan [this message]
2015-05-21 20:02 ` [PATCH v6 03/12] drm/exynos: atomic phase 1: add .mode_set_nofb() callback Gustavo Padovan
2015-05-22  3:46   ` Joonyoung Shim
2015-05-22 15:33     ` Gustavo Padovan
2015-05-27  8:43       ` Joonyoung Shim
2015-05-21 20:02 ` [PATCH v6 04/12] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() Gustavo Padovan
2015-05-22  3:46   ` Joonyoung Shim
2015-05-21 20:02 ` [PATCH v6 05/12] drm/exynos: atomic phase 2: keep track of framebuffer pointer Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 06/12] drm/exynos: atomic phase 3: atomic updates of planes Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 07/12] drm/exynos: atomic phase 3: use atomic .set_config helper Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 08/12] drm/exynos: atomic phase 3: convert page flips Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 09/12] drm/exynos: remove exported functions from exynos_drm_plane Gustavo Padovan
2015-05-22  3:47   ` Joonyoung Shim
2015-05-21 20:02 ` [PATCH v6 10/12] drm/exynos: don't disable unused functions at init Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 11/12] drm/exynos: atomic dpms support Gustavo Padovan
2015-05-22 13:00   ` Inki Dae
2015-05-22 15:35     ` Gustavo Padovan
2015-05-21 20:02 ` [PATCH v6 12/12] drm/exynos: remove unnecessary calls to disable_plane() Gustavo Padovan
2015-05-21 22:06 ` [PATCH v6 00/12] drm/exynos: atomic modesetting support Tobias Jakobi
2015-05-22  3:47 ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150522152945.GD14089@joana \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox