From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org, inki.dae@samsung.com,
sw0312.kim@samsung.com, m.szyprowski@samsung.com,
a.hajda@samsung.com
Subject: Re: [PATCH v2 3/3] drm/exynos: initialize VIDCON0 when fimd is disabled
Date: Mon, 15 Jun 2015 17:44:15 -0300 [thread overview]
Message-ID: <20150615204415.GC4650@joana> (raw)
In-Reply-To: <1434097636-10709-3-git-send-email-jy0922.shim@samsung.com>
Hi Joonyoung,
2015-06-12 Joonyoung Shim <jy0922.shim@samsung.com>:
> When the fimd is disabled by fimd_disable(), enabled overlay layers also
> are disabled. If clocks for fimd are enabled by fimd_enable() on this
> case, it can lead IOMMU page fault. The reason is that VIDCON0_ENVID and
> VIDCON0_ENVID_F bits of VIDCON0 register are set still even though fimd
> is disabled, so it may continue display output of prior when clocks for
> fimd are enabled again.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
next prev parent reply other threads:[~2015-06-15 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 8:27 [PATCH v2 1/3] drm/exynos: remove to call mixer_wait_for_vblank Joonyoung Shim
2015-06-12 8:27 ` [PATCH v2 2/3] drm/exynos: remove chained calls to enable Joonyoung Shim
2015-06-15 20:41 ` Gustavo Padovan
2015-06-12 8:27 ` [PATCH v2 3/3] drm/exynos: initialize VIDCON0 when fimd is disabled Joonyoung Shim
2015-06-15 20:44 ` Gustavo Padovan [this message]
2015-06-15 20:39 ` [PATCH v2 1/3] drm/exynos: remove to call mixer_wait_for_vblank Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615204415.GC4650@joana \
--to=gustavo.padovan@collabora.co.uk \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox