From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH v2] thermal: consistently use int for temperatures Date: Fri, 24 Jul 2015 08:29:48 +0200 Message-ID: <20150724062948.GK18700@pengutronix.de> References: <1437463292-24844-1-git-send-email-s.hauer@pengutronix.de> <20150723120759.GA17690@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150723120759.GA17690@amd> Sender: linux-pm-owner@vger.kernel.org To: Pavel Machek Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Punit Agrawal , Jean Delvare , Peter Feuerer , Heiko Stuebner , Lukasz Majewski , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Guenter Roeck , "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org List-Id: linux-samsung-soc@vger.kernel.org On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: > On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: > > The thermal code uses int, long and unsigned long for temperatures > > in different places. > >=20 > > Using an unsigned type limits the thermal framework to positive > > temperatures without need. Also several drivers currently will repo= rt > > temperatures near UINT_MAX for temperatures below 0=B0C. This will = probably > > immediately shut the machine down due to overtemperature if started= below > > 0=B0C. > >=20 > > 'long' is 64bit on several architectures. This is not needed since = INT_MAX =B0mC > > is above the melting point of all known materials. >=20 > Can we do something like >=20 > typedef millicelsius_t int; >=20 > ...to document the units? I am not very fond of typedefs and I am not sure this adds any value. I could change it when more people ask for it, but I just sent the new version without this. Sascha --=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 |