From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, m.szyprowski@samsung.com
Subject: Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
Date: Fri, 10 Jun 2016 16:11:14 +0200 [thread overview]
Message-ID: <20160610141114.GX3363@phenom.ffwll.local> (raw)
In-Reply-To: <20160610105450.GJ9217@imgtec.com>
On Fri, Jun 10, 2016 at 11:54:50AM +0100, Eric Engestrom wrote:
> On Wed, May 25, 2016 at 02:30:07PM +0200, Tobias Jakobi wrote:
> > The current bitwise AND should result in the same assembler
> > but this is what the code is actually supposed to do.
> >
> > Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Applied to drm-misc, thanks.
-Daniel
>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> > index b3f3c2c..e4a1a63 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> > @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
> > state->v_ratio == (1 << 15))
> > height_ok = true;
> >
> > - if (width_ok & height_ok)
> > + if (width_ok && height_ok)
> > return 0;
> >
> > DRM_DEBUG_KMS("scaling mode is not supported");
> > --
> > 2.7.3
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-10 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 12:30 [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size() Tobias Jakobi
2016-06-10 10:12 ` Tobias Jakobi
2016-06-13 1:34 ` Inki Dae
2016-06-13 6:34 ` Daniel Vetter
2016-06-10 10:54 ` Eric Engestrom
2016-06-10 14:11 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610141114.GX3363@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.engestrom@imgtec.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox