From: Daniel Vetter <daniel@ffwll.ch>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: make fbdev support really optional
Date: Tue, 12 Jul 2016 12:57:42 +0200 [thread overview]
Message-ID: <20160712105742.GG23520@phenom.ffwll.local> (raw)
In-Reply-To: <577D0CD9.9020607@math.uni-bielefeld.de>
On Wed, Jul 06, 2016 at 03:51:21PM +0200, Tobias Jakobi wrote:
> Ping!
Applied to drm-misc, thanks for the patch. Aside: I think there's other
drivers which get this wrong, with the generic support to make fbdev
optional in the drm core none of this should be needed anywhere. Can I
volunteer you to double check other Kconfig files in drm for the same
mistake?
Thanks, Daniel
>
> - Tobias
>
> Tobias Jakobi wrote:
> > Currently enabling Exynos DRM support automatically pulls in
> > lots of fbdev dependencies. However these deps are
> > unnecessary since DRM core already enables them when
> > needed.
> >
> > Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> > ---
> > drivers/gpu/drm/exynos/Kconfig | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> > index baddf33..590559c 100644
> > --- a/drivers/gpu/drm/exynos/Kconfig
> > +++ b/drivers/gpu/drm/exynos/Kconfig
> > @@ -2,10 +2,6 @@ config DRM_EXYNOS
> > tristate "DRM Support for Samsung SoC EXYNOS Series"
> > depends on OF && DRM && (ARCH_S3C64XX || ARCH_EXYNOS || ARCH_MULTIPLATFORM)
> > select DRM_KMS_HELPER
> > - select DRM_KMS_FB_HELPER
> > - select FB_CFB_FILLRECT
> > - select FB_CFB_COPYAREA
> > - select FB_CFB_IMAGEBLIT
> > select VIDEOMODE_HELPERS
> > help
> > Choose this option if you have a Samsung SoC EXYNOS chipset.
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-07-12 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 11:52 [PATCH] drm/exynos: make fbdev support really optional Tobias Jakobi
2016-07-06 13:51 ` Tobias Jakobi
2016-07-12 10:57 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712105742.GG23520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox