From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 1/2] drm/exynos/vidi: use timer for vblanks instead of sleeping worker Date: Fri, 23 Sep 2016 15:27:41 +0300 Message-ID: <20160923122741.GA30511@joana> References: <1474618524-8916-1-git-send-email-a.hajda@samsung.com> <1474618524-8916-2-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:36780 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758823AbcIWM1o (ORCPT ); Fri, 23 Sep 2016 08:27:44 -0400 Received: by mail-lf0-f68.google.com with SMTP id s29so5631384lfg.3 for ; Fri, 23 Sep 2016 05:27:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1474618524-8916-2-git-send-email-a.hajda@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Andrzej Hajda Cc: Inki Dae , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Daniel Vetter , dri-devel@lists.freedesktop.org, Tobias Jakobi , Marek Szyprowski 2016-09-23 Andrzej Hajda : > VIDI driver uses fake vblank handler to generate vblank events. > It was implemented using worker which slept for vblank time, additionally > it did not work if there were no page flips. The patch replaces it with > timer, uses drm_crtc_vblank_(on|off) helpers to manage it and fixes > behavior for non-page-flip cases. > This change allows further improvements of vblank in exynos-drm framework. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 66 ++++++++++---------------------- > 1 file changed, 20 insertions(+), 46 deletions(-) Reviewed-by: Gustavo Padovan Gustavo