From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v2 0/5] PCI: exynos: Cleanups Date: Wed, 12 Oct 2016 11:05:28 -0500 Message-ID: <20161012160528.GN4308@localhost> References: <20161012133428.28194.54006.stgit@bhelgaas-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161012133428.28194.54006.stgit@bhelgaas-glaptop2.roam.corp.google.com> Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Jingoo Han , Krzysztof Kozlowski , Kukjin Kim , linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On Wed, Oct 12, 2016 at 08:37:07AM -0500, Bjorn Helgaas wrote: > - Add local "dev" pointers to reduce repetition of things like > "&pdev->dev". > > - Name private struct pointer consistently within driver. > > - Pass device-specific struct to internal functions for consistency. > > Nothing here should change the behavior of the driver. > > Changes from v1: > I dropped the following patches because they were a lot of churn for > questionable benefit: > PCI: exynos: Name private struct pointer "exynos" consistently > (Instead of renaming *all* the pointers, I only renamed enough to > make them consistent within this file.) > PCI: exynos: Swap order of exynos_elb_writel() reg/val arguments > PCI: exynos: Swap order of exynos_phy_writel() reg/val arguments > PCI: exynos: Swap order of exynos_blk_writel() reg/val arguments > > --- > > Bjorn Helgaas (5): > PCI: exynos: Add local struct device pointers > PCI: exynos: Uninline register accessors > PCI: exynos: Name private struct pointer "exynos_pcie" consistently > PCI: exynos: Pass device-specific struct to internal functions > PCI: exynos: Reorder struct exynos_pcie > > > drivers/pci/host/pci-exynos.c | 214 +++++++++++++++++++---------------------- > 1 file changed, 100 insertions(+), 114 deletions(-) I applied these to pci/host-exynos for v4.9. I hope to ask Linus to pull them tomorrow, so if you see any issues, let me know soon.