From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kukjin Kim <kgene@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] [v2] ARM: s3c24xx: make H1940BT depend on RFKILL
Date: Thu, 20 Jul 2017 21:30:38 +0200 [thread overview]
Message-ID: <20170720193038.GA16488@kozik-book> (raw)
In-Reply-To: <20170720155410.3251043-1-arnd@arndb.de>
On Thu, Jul 20, 2017 at 05:53:43PM +0200, Arnd Bergmann wrote:
> Bluetooth is only supported when network support is part of the kernel,
> so it is a bit pointless to build the hi1940-bt support without networking.
> If we try anyway, we get a Kconfig warning:
>
> warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET)
>
> This turns the 'select' into 'depends on' as Krzysztof suggested when
> I first sent a fix.
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Link: https://patchwork.kernel.org/patch/8164161/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v1 was sent in Jan 2016, and instead added a dependency on CONFIG_NET
> ---
> arch/arm/mach-s3c24xx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied.
Best regards,
Krzysztof
prev parent reply other threads:[~2017-07-20 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 15:45 [PATCH 00/12] ARM: randconfig patches for platforms Arnd Bergmann
2017-07-20 15:53 ` [PATCH 10/12] [v2] ARM: s3c24xx: make H1940BT depend on RFKILL Arnd Bergmann
2017-07-20 19:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720193038.GA16488@kozik-book \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox