From: Sinclair Yeh <syeh@vmware.com>
To: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Cc: alexandre.belloni@bootlin.com, airlied@linux.ie,
liviu.dudau@arm.com, dri-devel@lists.freedesktop.org,
laurent.pinchart@ideasonboard.com, thellstrom@vmware.com,
krzk@kernel.org, maxime.ripard@bootlin.com, wens@csie.org,
kgene@kernel.org, malidp@foss.arm.com,
linux-graphics-maintainer@vmware.com, sunpeng.li@amd.com,
boris.brezillon@bootlin.com, linux-samsung-soc@vger.kernel.org,
nd@arm.com, Tony.Cheng@amd.com,
linux-arm-kernel@lists.infradead.org, sw0312.kim@samsung.com,
nicolas.ferre@microchip.com, shirish.s@amd.com,
kyungmin.park@samsung.com, alexander.deucher@amd.com,
christian.koenig@amd.com
Subject: Re: [PATCH 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic
Date: Mon, 23 Jul 2018 11:02:07 -0700 [thread overview]
Message-ID: <20180723180206.GA4877@promb-2n-dhcp82.eng.vmware.com> (raw)
In-Reply-To: <20180720211509.23605-11-alexandru-cosmin.gheorghe@arm.com>
Hello Alex,
other than adding a brief commit message to this patch,
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
On Fri, Jul 20, 2018 at 10:15:09PM +0100, Alexandru Gheorghe wrote:
> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 466336b34fff..1e0fb3c79b50 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -720,9 +720,7 @@ void vmw_du_plane_reset(struct drm_plane *plane)
> return;
> }
>
> - plane->state = &vps->base;
> - plane->state->plane = plane;
> - plane->state->rotation = DRM_MODE_ROTATE_0;
> + __drm_atomic_helper_plane_reset(plane, &vps->base);
> }
>
>
> --
> 2.18.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-23 18:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180713161407.GQ20303@art_vandelay>
2018-07-20 21:14 ` [PATCH 00/10] Add helper for plane reset Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe
2018-07-23 9:37 ` Ayan Halder
2018-07-24 7:48 ` Philipp Zabel
2018-07-24 8:14 ` Alexandru-Cosmin Gheorghe
2018-07-24 8:16 ` Boris Brezillon
2018-07-24 9:28 ` Alexandru-Cosmin Gheorghe
2018-07-20 21:15 ` [PATCH 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 03/10] drm: mali-dp: " Alexandru Gheorghe
2018-07-23 9:35 ` Ayan Halder
2018-07-24 8:26 ` Liviu Dudau
2018-07-20 21:15 ` [PATCH 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe
2018-07-21 6:12 ` Boris Brezillon
2018-07-20 21:15 ` [PATCH 05/10] drm/exynos: " Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 06/10] drm/imx: " Alexandru Gheorghe
2018-07-24 7:49 ` Philipp Zabel
2018-07-24 7:51 ` Philipp Zabel
2018-07-20 21:15 ` [PATCH 07/10] drm: rcar-du: " Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 08/10] drm/sun4i: " Alexandru Gheorghe
2018-07-20 21:15 ` [PATCH 09/10] drm/vc4: " Alexandru Gheorghe
2018-07-24 6:57 ` Maxime Ripard
2018-07-24 8:11 ` Alexandru-Cosmin Gheorghe
2018-07-24 12:54 ` Maxime Ripard
2018-07-20 21:15 ` [PATCH 10/10] drm/vmwgfx: " Alexandru Gheorghe
2018-07-23 17:16 ` Deepak Singh Rawat
2018-07-23 18:02 ` Sinclair Yeh [this message]
2018-07-24 15:31 ` [PATCH 00/10] Add helper for plane reset Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723180206.GA4877@promb-2n-dhcp82.eng.vmware.com \
--to=syeh@vmware.com \
--cc=Tony.Cheng@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru-cosmin.gheorghe@arm.com \
--cc=boris.brezillon@bootlin.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=malidp@foss.arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=nd@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=shirish.s@amd.com \
--cc=sunpeng.li@amd.com \
--cc=sw0312.kim@samsung.com \
--cc=thellstrom@vmware.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox