From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B52CC433DF for ; Tue, 7 Jul 2020 18:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 382D120708 for ; Tue, 7 Jul 2020 18:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZRAbnoYe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728575AbgGGSoQ (ORCPT ); Tue, 7 Jul 2020 14:44:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728260AbgGGSoQ (ORCPT ); Tue, 7 Jul 2020 14:44:16 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCA3EC08C5E1 for ; Tue, 7 Jul 2020 11:44:15 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id k6so46340689wrn.3 for ; Tue, 07 Jul 2020 11:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=ZRAbnoYeouFM1/H/tYHdc9ipGYXv4euR+tMeEcMnO6WGF+gx2vOHZ4Tr2eFazJkkEd 60O4ahEF6Nj58WW0Cz/gPtEuDUawAmWRgAMaG1Cf0x7Ne+IyOSwGIFVz/Dsbq7Pk8OMJ kGCTxQvmAj6NBIe7P5YI8MNpEf34m1t7jt74o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=lKx3+HYAVnC+mSVoTGl9SW9xSe3PgBk/oGWk73nZxU4wK9ReiFy42d13JNtcyd2gM+ sYv+JAekN08YHgp2MepKgkjx0WJj/owP3lLzIzoos8m9SALgEas4ilZrIvf9CaMZ+pOs Ta9yMTAo3x78X2e+FgKEMOCfgHnKyzzPbwLjJQM1qeRZJoV4Xqd4JiNZQQFWTYND5viS EsKnvVzdBHnUNikxSgrOQ0wE2KLf+k+XwHdCibe2xr+18FRnc1O6iYmsfMxAnLnXQWXa 0mdjDCqfWHdjKhP//+ntfJraOYE9PO6zYkdcmRH5PgnTDO1zi5RJMifCZ2HbJlzYbe1k KlJg== X-Gm-Message-State: AOAM531MuOJwsriXxPVp0nJpBqoVIe+egRgTiGW2RLO//LBx1qA1RKn9 a5e5POOXb5t6g8kbSWjt6UpXIg== X-Google-Smtp-Source: ABdhPJxgjESKdQWY9pLtFBqLyAUIW60bnRZRaPezyKkNG1iu3kU0qO+BJCOsPvxhOCFHBejqU6mveA== X-Received: by 2002:adf:8444:: with SMTP id 62mr52648218wrf.278.1594147454606; Tue, 07 Jul 2020 11:44:14 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id u186sm2173926wmu.10.2020.07.07.11.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:44:14 -0700 (PDT) Date: Tue, 7 Jul 2020 18:44:12 +0000 From: Tomasz Figa To: Jonathan Bakker Cc: kyungmin.park@samsung.com, s.nawrocki@samsung.com, mchehab@kernel.org, kgene@kernel.org, krzk@kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop Message-ID: <20200707184412.GJ2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:49PM -0700, Jonathan Bakker wrote: > media_pipeline_stop can be called from both release and streamoff, > so make sure they're both protected under the streaming flag and > not just one of them. First of all, thanks for the patch. Shouldn't it be that release calls streamoff, so that only streamoff is supposed to have the call to media_pipeline_stop()? Best regards, Tomasz