Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds

Ahmad Fatoum
2020-10-27T10:58:30Z

Hello,

On 10/27/20 11:05 AM, Alexander Dahl wrote:
> Hello Ahmad,
>
> thanks for your feedback, comments below.
>

>>> - led-rgb {
>>> + led-controller-2 {
>>
>> Is a single RGB LED really a controller?
>
> I just followed the recommendations by Rob here.

Do you happen to know if the new multicolor LED support could be used here?

I find it unfortunate that the device tree loses information relevant to humans
to adhere to a fixed nomenclature. Apparently led-controller isn't even codified
in the YAML binding (It's just in the examples). If you respin, please add a
comment that this is a single RGB led. I'd prefer to keep the information
in the DTB as well though.

>
>>> compatible = "pwm-leds";
>>>
>>> - led-red {
>>> + led-2 {
>>
>> Shouldn't this have been led-1 as well or is the numbering "global" ?
>
> Also good question. This numbering is for dts only, it usually does
> not correspond with LEDs on the board, so it could be numbered per
> led-controller as well?

I'd prefer that it starts by 1. That way it's aligned with PWM channel
ID.

Thanks for fixing the dtschema warnings by the way!

Cheers,
Ahmad

>
> Greets
> Alex
>
>>
>>> label = "mc1:red:rgb";
>>> pwms = <&leds_pwm 1 1000000 0>;
>>> max-brightness = <255>;
>>> active-low;
>>> };
>>>
>>> - led-green {
>>> + led-3 {
>>> label = "mc1:green:rgb";
>>> pwms = <&leds_pwm 2 1000000 0>;
>>> max-brightness = <255>;
>>> active-low;
>>> };
>>>
>>> - led-blue {
>>> + led-4 {
>>> label = "mc1:blue:rgb";
>>> pwms = <&leds_pwm 3 1000000 0>;
>>> max-brightness = <255>;
>>>
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |