From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Joel Stanley" <joel@jms.id.au>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Nicolas Pitre" <nico@fluxnic.net>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region
Date: Wed, 28 Oct 2020 13:00:50 +0000 [thread overview]
Message-ID: <20201028130050.GL1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAMj1kXH90MzCUJ_DHZ_2=JcWBX=Qf1PT-A9PX9EeBTVx22EkaQ@mail.gmail.com>
On Wed, Oct 28, 2020 at 01:52:48PM +0100, Ard Biesheuvel wrote:
> Does this help?
>
> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
> index bb79e52aeb90..4f355bda872a 100644
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -68,8 +68,8 @@
> #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff))
>
> #define FDT_FIXED_BASE UL(0xff800000)
> -#define FDT_FIXED_SIZE (2 * PMD_SIZE)
> -#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE |
> (physaddr) % PMD_SIZE))
> +#define FDT_FIXED_SIZE (2 * SECTION_SIZE)
> +#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE |
> (physaddr) % SECTION_SIZE))
Is this correct? If the FDT fixed size is 2x, why does FDT_VIRT_ADDR()
only work for half of it?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-28 22:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201007083944.27910-1-ardb@kernel.org>
[not found] ` <CGME20201028091912eucas1p13fb9cd947faa6bfd79199ea79648b6af@eucas1p1.samsung.com>
[not found] ` <20201007083944.27910-3-ardb@kernel.org>
2020-10-28 9:19 ` [PATCH v2 2/2] ARM: move device tree mapping out of linear region Marek Szyprowski
2020-10-28 9:22 ` Ard Biesheuvel
2020-10-28 9:24 ` Ard Biesheuvel
2020-10-28 9:43 ` Marek Szyprowski
2020-10-28 12:05 ` Joel Stanley
2020-10-28 12:52 ` Ard Biesheuvel
2020-10-28 12:59 ` Joel Stanley
2020-10-28 13:00 ` Ard Biesheuvel
2020-10-28 13:06 ` Joel Stanley
2020-10-28 13:00 ` Russell King - ARM Linux admin [this message]
2020-10-28 13:04 ` Ard Biesheuvel
2020-10-28 13:09 ` Russell King - ARM Linux admin
2020-10-28 13:16 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028130050.GL1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=clg@kaod.org \
--cc=f.fainelli@gmail.com \
--cc=joel@jms.id.au \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nico@fluxnic.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox