Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: Enable DWC2 dual-role support on OdroidU3+ boards
Date: Thu, 5 Nov 2020 20:10:32 +0100	[thread overview]
Message-ID: <20201105191032.GA226037@kozik-lap> (raw)
In-Reply-To: <20201103140214.21690-1-m.szyprowski@samsung.com>

On Tue, Nov 03, 2020 at 03:02:14PM +0100, Marek Szyprowski wrote:
> MicroUSB port on OdroidU3+ boards can operate both as peripheral or as
> host port. Till now it was configured as pheriperal only port, but it
> turned out that the DWC2 driver code already handles everything needed to
> support USB role-switch, so switch it to dual-role (OTG) mode. This has
> no effect on OdroidU3 (with 'plus') and OdroidX2, which doesn't have USB
> needed ID pin and VBUS wiring. Those will still operate correctly in
> pheriperal mode only.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi |  1 -
>  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 14 ++++++++++++++
>  arch/arm/boot/dts/exynos4412-odroidx.dts        |  4 ++++

Thanks, applied with corrected 'without', Anand's tag and node named
just "regulator-1" (X has one and it is more generic).

Best regards,
Krzysztof


      parent reply	other threads:[~2020-11-05 19:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201103140221eucas1p1c4479a8a89e7e9a05c7582462d79e5c7@eucas1p1.samsung.com>
2020-11-03 14:02 ` [PATCH] ARM: dts: exynos: Enable DWC2 dual-role support on OdroidU3+ boards Marek Szyprowski
2020-11-03 21:24   ` Marek Szyprowski
2020-11-05  7:48     ` Anand Moon
2020-11-05 19:10   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105191032.GA226037@kozik-lap \
    --to=krzk@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox