From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Fancy Fang <chen.fang@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Adam Ford <aford173@gmail.com>,
Neil Armstrong <narmstrong@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
Marek Vasut <marex@denx.de>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v10 13/18] drm: exynos: dsi: Add Exynos based host irq hooks
Date: Wed, 14 Dec 2022 18:29:02 +0530 [thread overview]
Message-ID: <20221214125907.376148-14-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com>
Enable and disable of te_gpio's are Exynos platform specific
irq handling, so add the exynos based irq operations and hook
them for exynos plat_data.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v10:
- split from previous series patch
"drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge"
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 55 +++++++++++++++++++++----
1 file changed, 47 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 819131a36b96..580e06595b37 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -291,9 +291,15 @@ struct exynos_dsim_host_ops {
int (*detach)(struct exynos_dsi *dsim, struct mipi_dsi_device *device);
};
+struct exynos_dsim_irq_ops {
+ void (*enable)(struct exynos_dsi *dsim);
+ void (*disable)(struct exynos_dsi *dsim);
+};
+
struct exynos_dsi_plat_data {
enum exynos_dsi_type hw_type;
const struct exynos_dsim_host_ops *host_ops;
+ const struct exynos_dsim_irq_ops *irq_ops;
};
struct exynos_dsi {
@@ -308,7 +314,6 @@ struct exynos_dsi {
struct clk **clks;
struct regulator_bulk_data supplies[2];
int irq;
- struct gpio_desc *te_gpio;
u32 pll_clk_rate;
u32 burst_clk_rate;
@@ -332,6 +337,7 @@ struct exynos_dsi {
struct exynos_dsi_enc {
struct drm_encoder encoder;
+ struct gpio_desc *te_gpio;
};
#define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host)
@@ -1345,18 +1351,38 @@ static irqreturn_t exynos_dsi_te_irq_handler(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static void exynos_dsi_enable_irq(struct exynos_dsi *dsi)
+static void _exynos_dsi_enable_irq(struct exynos_dsi *dsim)
{
- enable_irq(dsi->irq);
+ struct _exynos_dsi *dsi = dsim->priv;
if (dsi->te_gpio)
enable_irq(gpiod_to_irq(dsi->te_gpio));
}
-static void exynos_dsi_disable_irq(struct exynos_dsi *dsi)
+static void _exynos_dsi_disable_irq(struct exynos_dsi *dsim)
{
+ struct _exynos_dsi *dsi = dsim->priv;
+
if (dsi->te_gpio)
disable_irq(gpiod_to_irq(dsi->te_gpio));
+}
+
+static void exynos_dsi_enable_irq(struct exynos_dsi *dsi)
+{
+ const struct exynos_dsi_plat_data *pdata = dsi->plat_data;
+
+ enable_irq(dsi->irq);
+
+ if (pdata->irq_ops && pdata->irq_ops->enable)
+ pdata->irq_ops->enable(dsi);
+}
+
+static void exynos_dsi_disable_irq(struct exynos_dsi *dsi)
+{
+ const struct exynos_dsi_plat_data *pdata = dsi->plat_data;
+
+ if (pdata->irq_ops && pdata->irq_ops->disable)
+ pdata->irq_ops->disable(dsi);
disable_irq(dsi->irq);
}
@@ -1385,9 +1411,10 @@ static int exynos_dsi_init(struct exynos_dsi *dsi)
return 0;
}
-static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
+static int exynos_dsi_register_te_irq(struct exynos_dsi *dsim,
struct device *panel)
{
+ struct _exynos_dsi *dsi = dsim->priv;
int ret;
int te_gpio_irq;
@@ -1395,7 +1422,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
if (!dsi->te_gpio) {
return 0;
} else if (IS_ERR(dsi->te_gpio)) {
- dev_err(dsi->dev, "gpio request failed with %ld\n",
+ dev_err(dsim->dev, "gpio request failed with %ld\n",
PTR_ERR(dsi->te_gpio));
return PTR_ERR(dsi->te_gpio);
}
@@ -1405,7 +1432,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
ret = request_threaded_irq(te_gpio_irq, exynos_dsi_te_irq_handler, NULL,
IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN, "TE", dsi);
if (ret) {
- dev_err(dsi->dev, "request interrupt failed with %d\n", ret);
+ dev_err(dsim->dev, "request interrupt failed with %d\n", ret);
gpiod_put(dsi->te_gpio);
return ret;
}
@@ -1413,8 +1440,10 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
return 0;
}
-static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsi)
+static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsim)
{
+ struct _exynos_dsi *dsi = dsim->priv;
+
if (dsi->te_gpio) {
free_irq(gpiod_to_irq(dsi->te_gpio), dsi);
gpiod_put(dsi->te_gpio);
@@ -2035,6 +2064,11 @@ static const struct dev_pm_ops exynos_dsi_pm_ops = {
pm_runtime_force_resume)
};
+static const struct exynos_dsim_irq_ops exynos_dsi_irq_ops = {
+ .enable = _exynos_dsi_enable_irq,
+ .disable = _exynos_dsi_disable_irq,
+};
+
static const struct exynos_dsim_host_ops exynos_dsi_host_ops = {
.register_host = exynos_dsi_register_host,
.unregister_host = exynos_dsi_unregister_host,
@@ -2045,26 +2079,31 @@ static const struct exynos_dsim_host_ops exynos_dsi_host_ops = {
static const struct exynos_dsi_plat_data exynos3250_dsi_pdata = {
.hw_type = DSIM_TYPE_EXYNOS3250,
.host_ops = &exynos_dsi_host_ops,
+ .irq_ops = &exynos_dsi_irq_ops,
};
static const struct exynos_dsi_plat_data exynos4210_dsi_pdata = {
.hw_type = DSIM_TYPE_EXYNOS4210,
.host_ops = &exynos_dsi_host_ops,
+ .irq_ops = &exynos_dsi_irq_ops,
};
static const struct exynos_dsi_plat_data exynos5410_dsi_pdata = {
.hw_type = DSIM_TYPE_EXYNOS5410,
.host_ops = &exynos_dsi_host_ops,
+ .irq_ops = &exynos_dsi_irq_ops,
};
static const struct exynos_dsi_plat_data exynos5422_dsi_pdata = {
.hw_type = DSIM_TYPE_EXYNOS5422,
.host_ops = &exynos_dsi_host_ops,
+ .irq_ops = &exynos_dsi_irq_ops,
};
static const struct exynos_dsi_plat_data exynos5433_dsi_pdata = {
.hw_type = DSIM_TYPE_EXYNOS5433,
.host_ops = &exynos_dsi_host_ops,
+ .irq_ops = &exynos_dsi_irq_ops,
};
static const struct of_device_id exynos_dsi_of_match[] = {
--
2.25.1
next prev parent reply other threads:[~2022-12-14 13:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 12:58 [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2022-12-14 12:58 ` [PATCH v10 01/18] drm: of: Lookup if child node has DSI panel or bridge Jagan Teki
2022-12-14 12:58 ` [PATCH v10 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper Jagan Teki
2022-12-14 12:58 ` [PATCH v10 03/18] drm: exynos: dsi: Drop explicit call to bridge detach Jagan Teki
2022-12-14 12:58 ` [PATCH v10 04/18] drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge Jagan Teki
2022-12-14 12:58 ` [PATCH v10 05/18] drm: exynos: dsi: Mark PHY as optional Jagan Teki
2022-12-15 8:33 ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Jagan Teki
2022-12-14 12:58 ` [PATCH v10 07/18] drm: exynos: dsi: Introduce hw_type platform data Jagan Teki
2022-12-15 8:35 ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 08/18] drm: exynos: dsi: Handle proper host initialization Jagan Teki
2022-12-15 8:37 ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 09/18] drm: exynos: dsi: Add atomic check Jagan Teki
2022-12-15 8:39 ` Frieder Schrempf
2022-12-15 8:40 ` Frieder Schrempf
2022-12-14 12:58 ` [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags Jagan Teki
2022-12-15 8:42 ` Frieder Schrempf
2022-12-14 12:59 ` [PATCH v10 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts Jagan Teki
2022-12-15 8:57 ` Frieder Schrempf
2022-12-14 12:59 ` [PATCH v10 12/18] drm: exynos: dsi: Consolidate component and bridge Jagan Teki
2022-12-14 12:59 ` Jagan Teki [this message]
2022-12-14 12:59 ` [PATCH v10 15/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support Jagan Teki
2022-12-14 12:59 ` [PATCH v10 16/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-12-15 9:22 ` Frieder Schrempf
2022-12-15 11:39 ` Robert Foss
2022-12-14 12:59 ` [PATCH v10 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support Jagan Teki
2022-12-20 17:26 ` Rob Herring
2022-12-14 12:59 ` [PATCH v10 18/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-12-15 9:23 ` Frieder Schrempf
2022-12-15 11:39 ` Robert Foss
2023-01-05 10:24 ` [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2023-01-06 14:34 ` Adam Ford
2023-01-06 14:42 ` Fabio Estevam
2023-01-19 17:27 ` Fabio Estevam
2023-01-19 17:58 ` Jagan Teki
2023-01-20 12:06 ` Fabio Estevam
2023-01-20 14:41 ` Jagan Teki
2023-01-20 15:06 ` Marek Vasut
2023-01-20 18:54 ` Jagan Teki
2023-01-20 19:08 ` Marek Vasut
2023-01-20 18:59 ` Dave Stevenson
2023-01-23 12:22 ` Jagan Teki
2023-01-23 15:48 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214125907.376148-14-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aford173@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=chen.fang@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marex@denx.de \
--cc=matteo.lisi@engicam.com \
--cc=michael@amarulasolutions.com \
--cc=narmstrong@linaro.org \
--cc=robert.foss@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=tharvey@gateworks.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox