* [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support
@ 2025-08-19 12:10 Tudor Ambarus
2025-08-19 12:10 ` [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks Tudor Ambarus
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Tudor Ambarus @ 2025-08-19 12:10 UTC (permalink / raw)
To: Peter Griffin, André Draszik, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Catalin Marinas,
Will Deacon
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
willmcvicker, kernel-team, Tudor Ambarus
Define the CPU clocks and OPPs.
Bindings for the "google,gs101-acpm-dvfs-clocks" compatible are sent at:
https://lore.kernel.org/linux-samsung-soc/20250819-acpm-clk-v1-0-6bbd97474671@linaro.org/T/#me3cbe2a97485d19eaf505ad23202f20a21305dd8
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
Tudor Ambarus (3):
arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks
arm64: dts: exynos: gs101: add CPU clocks
arm64: dts: exynos: gs101: add OPPs
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 288 +++++++++++++++++++++++++++
1 file changed, 288 insertions(+)
---
base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
change-id: 20250819-acpm-dvfs-dt-06bc794bdccd
Best regards,
--
Tudor Ambarus <tudor.ambarus@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks
2025-08-19 12:10 [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Tudor Ambarus
@ 2025-08-19 12:10 ` Tudor Ambarus
2025-08-24 17:02 ` Krzysztof Kozlowski
2025-08-19 12:10 ` [PATCH 2/3] arm64: dts: exynos: gs101: add CPU clocks Tudor Ambarus
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Tudor Ambarus @ 2025-08-19 12:10 UTC (permalink / raw)
To: Peter Griffin, André Draszik, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Catalin Marinas,
Will Deacon
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
willmcvicker, kernel-team, Tudor Ambarus
Define the clocks exposed by the ACPM interface.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index c0f8c25861a9ddb5bbd256b62c66a645922ca74e..d010b8ffc4e09562519d6796691fe573c68b7ac7 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -204,6 +204,11 @@ acpm_ipc: power-management {
compatible = "google,gs101-acpm-ipc";
mboxes = <&ap2apm_mailbox>;
shmem = <&apm_sram>;
+
+ acpm_dvfs_clocks: clocks {
+ compatible = "google,gs101-acpm-dvfs-clocks";
+ #clock-cells = <1>;
+ };
};
};
--
2.51.0.rc1.167.g924127e9c0-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] arm64: dts: exynos: gs101: add CPU clocks
2025-08-19 12:10 [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Tudor Ambarus
2025-08-19 12:10 ` [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks Tudor Ambarus
@ 2025-08-19 12:10 ` Tudor Ambarus
2025-08-24 17:01 ` Krzysztof Kozlowski
2025-08-19 12:10 ` [PATCH 3/3] arm64: dts: exynos: gs101: add OPPs Tudor Ambarus
2025-08-19 15:22 ` [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Rob Herring (Arm)
3 siblings, 1 reply; 8+ messages in thread
From: Tudor Ambarus @ 2025-08-19 12:10 UTC (permalink / raw)
To: Peter Griffin, André Draszik, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Catalin Marinas,
Will Deacon
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
willmcvicker, kernel-team, Tudor Ambarus
The GS101 CPU clocks are exposed through the ACPM protocol. Add them.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index d010b8ffc4e09562519d6796691fe573c68b7ac7..42926f8bde8889ec99ecf9fc551629a0453e788f 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -72,6 +72,7 @@ cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0000>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL0>;
enable-method = "psci";
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
@@ -82,6 +83,7 @@ cpu1: cpu@100 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0100>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL0>;
enable-method = "psci";
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
@@ -92,6 +94,7 @@ cpu2: cpu@200 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0200>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL0>;
enable-method = "psci";
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
@@ -102,6 +105,7 @@ cpu3: cpu@300 {
device_type = "cpu";
compatible = "arm,cortex-a55";
reg = <0x0300>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL0>;
enable-method = "psci";
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
@@ -112,6 +116,7 @@ cpu4: cpu@400 {
device_type = "cpu";
compatible = "arm,cortex-a76";
reg = <0x0400>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL1>;
enable-method = "psci";
cpu-idle-states = <&enyo_cpu_sleep>;
capacity-dmips-mhz = <620>;
@@ -122,6 +127,7 @@ cpu5: cpu@500 {
device_type = "cpu";
compatible = "arm,cortex-a76";
reg = <0x0500>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL1>;
enable-method = "psci";
cpu-idle-states = <&enyo_cpu_sleep>;
capacity-dmips-mhz = <620>;
@@ -132,6 +138,7 @@ cpu6: cpu@600 {
device_type = "cpu";
compatible = "arm,cortex-x1";
reg = <0x0600>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL2>;
enable-method = "psci";
cpu-idle-states = <&hera_cpu_sleep>;
capacity-dmips-mhz = <1024>;
@@ -142,6 +149,7 @@ cpu7: cpu@700 {
device_type = "cpu";
compatible = "arm,cortex-x1";
reg = <0x0700>;
+ clocks = <&acpm_dvfs_clocks CLK_ACPM_DVFS_CPUCL2>;
enable-method = "psci";
cpu-idle-states = <&hera_cpu_sleep>;
capacity-dmips-mhz = <1024>;
--
2.51.0.rc1.167.g924127e9c0-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: gs101: add OPPs
2025-08-19 12:10 [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Tudor Ambarus
2025-08-19 12:10 ` [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks Tudor Ambarus
2025-08-19 12:10 ` [PATCH 2/3] arm64: dts: exynos: gs101: add CPU clocks Tudor Ambarus
@ 2025-08-19 12:10 ` Tudor Ambarus
2025-08-19 15:22 ` [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Rob Herring (Arm)
3 siblings, 0 replies; 8+ messages in thread
From: Tudor Ambarus @ 2025-08-19 12:10 UTC (permalink / raw)
To: Peter Griffin, André Draszik, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Catalin Marinas,
Will Deacon
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
willmcvicker, kernel-team, Tudor Ambarus
Add operating performance points (OPPs).
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 275 +++++++++++++++++++++++++++
1 file changed, 275 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 42926f8bde8889ec99ecf9fc551629a0453e788f..b2303b3a3d176ef9b825d24bbe0bb0d51ef81246 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -77,6 +77,7 @@ cpu0: cpu@0 {
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
dynamic-power-coefficient = <70>;
+ operating-points-v2 = <&cpucl0_opp_table>;
};
cpu1: cpu@100 {
@@ -88,6 +89,7 @@ cpu1: cpu@100 {
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
dynamic-power-coefficient = <70>;
+ operating-points-v2 = <&cpucl0_opp_table>;
};
cpu2: cpu@200 {
@@ -99,6 +101,7 @@ cpu2: cpu@200 {
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
dynamic-power-coefficient = <70>;
+ operating-points-v2 = <&cpucl0_opp_table>;
};
cpu3: cpu@300 {
@@ -110,6 +113,7 @@ cpu3: cpu@300 {
cpu-idle-states = <&ananke_cpu_sleep>;
capacity-dmips-mhz = <250>;
dynamic-power-coefficient = <70>;
+ operating-points-v2 = <&cpucl0_opp_table>;
};
cpu4: cpu@400 {
@@ -121,6 +125,7 @@ cpu4: cpu@400 {
cpu-idle-states = <&enyo_cpu_sleep>;
capacity-dmips-mhz = <620>;
dynamic-power-coefficient = <284>;
+ operating-points-v2 = <&cpucl1_opp_table>;
};
cpu5: cpu@500 {
@@ -132,6 +137,7 @@ cpu5: cpu@500 {
cpu-idle-states = <&enyo_cpu_sleep>;
capacity-dmips-mhz = <620>;
dynamic-power-coefficient = <284>;
+ operating-points-v2 = <&cpucl1_opp_table>;
};
cpu6: cpu@600 {
@@ -143,6 +149,7 @@ cpu6: cpu@600 {
cpu-idle-states = <&hera_cpu_sleep>;
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <650>;
+ operating-points-v2 = <&cpucl2_opp_table>;
};
cpu7: cpu@700 {
@@ -154,6 +161,7 @@ cpu7: cpu@700 {
cpu-idle-states = <&hera_cpu_sleep>;
capacity-dmips-mhz = <1024>;
dynamic-power-coefficient = <650>;
+ operating-points-v2 = <&cpucl2_opp_table>;
};
idle-states {
@@ -191,6 +199,273 @@ hera_cpu_sleep: cpu-hera-sleep {
};
};
+ cpucl0_opp_table: opp-table-0 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-300000000 {
+ opp-hz = /bits/ 64 <300000000>;
+ opp-microvolt = <537500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-574000000 {
+ opp-hz = /bits/ 64 <574000000>;
+ opp-microvolt = <600000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-738000000 {
+ opp-hz = /bits/ 64 <738000000>;
+ opp-microvolt = <618750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-930000000 {
+ opp-hz = /bits/ 64 <930000000>;
+ opp-microvolt = <668750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1098000000 {
+ opp-hz = /bits/ 64 <1098000000>;
+ opp-microvolt = <712500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1197000000 {
+ opp-hz = /bits/ 64 <1197000000>;
+ opp-microvolt = <731250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1328000000 {
+ opp-hz = /bits/ 64 <1328000000>;
+ opp-microvolt = <762500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1401000000 {
+ opp-hz = /bits/ 64 <1401000000>;
+ opp-microvolt = <781250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1598000000 {
+ opp-hz = /bits/ 64 <1598000000>;
+ opp-microvolt = <831250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1704000000 {
+ opp-hz = /bits/ 64 <1704000000>;
+ opp-microvolt = <862500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1803000000 {
+ opp-hz = /bits/ 64 <1803000000>;
+ opp-microvolt = <906250>;
+ clock-latency-ns = <5000000>;
+ };
+ };
+
+ cpucl1_opp_table: opp-table-1 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-400000000 {
+ opp-hz = /bits/ 64 <400000000>;
+ opp-microvolt = <506250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-553000000 {
+ opp-hz = /bits/ 64 <553000000>;
+ opp-microvolt = <537500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-696000000 {
+ opp-hz = /bits/ 64 <696000000>;
+ opp-microvolt = <562500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-799000000 {
+ opp-hz = /bits/ 64 <799000000>;
+ opp-microvolt = <581250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-910000000 {
+ opp-hz = /bits/ 64 <910000000>;
+ opp-microvolt = <606250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1024000000 {
+ opp-hz = /bits/ 64 <1024000000>;
+ opp-microvolt = <625000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1197000000 {
+ opp-hz = /bits/ 64 <1197000000>;
+ opp-microvolt = <662500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1328000000 {
+ opp-hz = /bits/ 64 <1328000000>;
+ opp-microvolt = <687500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1491000000 {
+ opp-hz = /bits/ 64 <1491000000>;
+ opp-microvolt = <731250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1663000000 {
+ opp-hz = /bits/ 64 <1663000000>;
+ opp-microvolt = <775000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1836000000 {
+ opp-hz = /bits/ 64 <1836000000>;
+ opp-microvolt = <818750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1999000000 {
+ opp-hz = /bits/ 64 <1999000000>;
+ opp-microvolt = <868750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2130000000 {
+ opp-hz = /bits/ 64 <2130000000>;
+ opp-microvolt = <918750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2253000000 {
+ opp-hz = /bits/ 64 <2253000000>;
+ opp-microvolt = <968750>;
+ clock-latency-ns = <5000000>;
+ };
+ };
+
+ cpucl2_opp_table: opp-table-2 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-500000000 {
+ opp-hz = /bits/ 64 <500000000>;
+ opp-microvolt = <500000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-851000000 {
+ opp-hz = /bits/ 64 <851000000>;
+ opp-microvolt = <556250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-984000000 {
+ opp-hz = /bits/ 64 <984000000>;
+ opp-microvolt = <575000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1106000000 {
+ opp-hz = /bits/ 64 <1106000000>;
+ opp-microvolt = <606250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1277000000 {
+ opp-hz = /bits/ 64 <1277000000>;
+ opp-microvolt = <631250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1426000000 {
+ opp-hz = /bits/ 64 <1426000000>;
+ opp-microvolt = <662500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1582000000 {
+ opp-hz = /bits/ 64 <1582000000>;
+ opp-microvolt = <693750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1745000000 {
+ opp-hz = /bits/ 64 <1745000000>;
+ opp-microvolt = <731250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-1826000000 {
+ opp-hz = /bits/ 64 <1826000000>;
+ opp-microvolt = <750000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2048000000 {
+ opp-hz = /bits/ 64 <2048000000>;
+ opp-microvolt = <793750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2188000000 {
+ opp-hz = /bits/ 64 <2188000000>;
+ opp-microvolt = <831250>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2252000000 {
+ opp-hz = /bits/ 64 <2252000000>;
+ opp-microvolt = <850000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2401000000 {
+ opp-hz = /bits/ 64 <2401000000>;
+ opp-microvolt = <887500>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2507000000 {
+ opp-hz = /bits/ 64 <2507000000>;
+ opp-microvolt = <925000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2630000000 {
+ opp-hz = /bits/ 64 <2630000000>;
+ opp-microvolt = <968750>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2704000000 {
+ opp-hz = /bits/ 64 <2704000000>;
+ opp-microvolt = <1000000>;
+ clock-latency-ns = <5000000>;
+ };
+
+ opp-2802000000 {
+ opp-hz = /bits/ 64 <2802000000>;
+ opp-microvolt = <1056250>;
+ clock-latency-ns = <5000000>;
+ };
+ };
+
/* ect node is required to be present by bootloader */
ect {
};
--
2.51.0.rc1.167.g924127e9c0-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support
2025-08-19 12:10 [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Tudor Ambarus
` (2 preceding siblings ...)
2025-08-19 12:10 ` [PATCH 3/3] arm64: dts: exynos: gs101: add OPPs Tudor Ambarus
@ 2025-08-19 15:22 ` Rob Herring (Arm)
2025-08-20 5:34 ` Tudor Ambarus
3 siblings, 1 reply; 8+ messages in thread
From: Rob Herring (Arm) @ 2025-08-19 15:22 UTC (permalink / raw)
To: Tudor Ambarus
Cc: linux-samsung-soc, Will Deacon, kernel-team, Catalin Marinas,
Conor Dooley, André Draszik, Alim Akhtar, devicetree,
willmcvicker, Krzysztof Kozlowski, linux-arm-kernel,
Peter Griffin, linux-kernel
On Tue, 19 Aug 2025 12:10:19 +0000, Tudor Ambarus wrote:
> Define the CPU clocks and OPPs.
>
> Bindings for the "google,gs101-acpm-dvfs-clocks" compatible are sent at:
> https://lore.kernel.org/linux-samsung-soc/20250819-acpm-clk-v1-0-6bbd97474671@linaro.org/T/#me3cbe2a97485d19eaf505ad23202f20a21305dd8
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> Tudor Ambarus (3):
> arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks
> arm64: dts: exynos: gs101: add CPU clocks
> arm64: dts: exynos: gs101: add OPPs
>
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 288 +++++++++++++++++++++++++++
> 1 file changed, 288 insertions(+)
> ---
> base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
> change-id: 20250819-acpm-dvfs-dt-06bc794bdccd
>
> Best regards,
> --
> Tudor Ambarus <tudor.ambarus@linaro.org>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250819-acpm-dvfs-dt-v1-0-4e38b95408c4@linaro.org:
Error: arch/arm64/boot/dts/exynos/google/gs101.dtsi:75.32-33 Error: arch/arm64/boot/dts/exynos/google/gs101.dtsi:75.32-33 syntax errorsyntax error
FATAL ERROR: FATAL ERROR: Unable to parse input tree
Unable to parse input tree
make[4]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/exynos/google/gs101-raven.dtb] Error 1
make[4]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/exynos/google/gs101-oriole.dtb] Error 1
make[3]: *** [scripts/Makefile.build:556: arch/arm64/boot/dts/exynos/google] Error 2
make[3]: Target 'arch/arm64/boot/dts/exynos/google/gs101-raven.dtb' not remade because of errors.
make[3]: *** [scripts/Makefile.build:556: arch/arm64/boot/dts/exynos/google] Error 2
make[3]: Target 'arch/arm64/boot/dts/exynos/google/gs101-oriole.dtb' not remade because of errors.
make[2]: *** [scripts/Makefile.build:556: arch/arm64/boot/dts/exynos] Error 2
make[2]: Target 'arch/arm64/boot/dts/exynos/google/gs101-raven.dtb' not remade because of errors.
make[2]: *** [scripts/Makefile.build:556: arch/arm64/boot/dts/exynos] Error 2
make[2]: Target 'arch/arm64/boot/dts/exynos/google/gs101-oriole.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1480: exynos/google/gs101-raven.dtb] Error 2
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1480: exynos/google/gs101-oriole.dtb] Error 2
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'exynos/exynos8895-dreamlte.dtb' not remade because of errors.
make: Target 'exynos/exynos2200-g0s.dtb' not remade because of errors.
make: Target 'exynos/exynos850-e850-96.dtb' not remade because of errors.
make: Target 'exynos/exynos7870-on7xelte.dtb' not remade because of errors.
make: Target 'exynos/exynos7885-jackpotlte.dtb' not remade because of errors.
make: Target 'exynos/exynos990-x1slte.dtb' not remade because of errors.
make: Target 'exynos/exynos5433-tm2.dtb' not remade because of errors.
make: Target 'exynos/exynos990-r8s.dtb' not remade because of errors.
make: Target 'exynos/exynos7-espresso.dtb' not remade because of errors.
make: Target 'exynos/google/gs101-oriole.dtb' not remade because of errors.
make: Target 'exynos/google/gs101-raven.dtb' not remade because of errors.
make: Target 'exynos/exynosautov920-sadk.dtb' not remade because of errors.
make: Target 'exynos/exynosautov9-sadk.dtb' not remade because of errors.
make: Target 'exynos/exynos990-c1s.dtb' not remade because of errors.
make: Target 'exynos/exynos9810-starlte.dtb' not remade because of errors.
make: Target 'exynos/exynos990-x1s.dtb' not remade because of errors.
make: Target 'exynos/exynos7870-a2corelte.dtb' not remade because of errors.
make: Target 'exynos/exynos5433-tm2e.dtb' not remade because of errors.
make: Target 'exynos/exynos7870-j6lte.dtb' not remade because of errors.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support
2025-08-19 15:22 ` [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Rob Herring (Arm)
@ 2025-08-20 5:34 ` Tudor Ambarus
0 siblings, 0 replies; 8+ messages in thread
From: Tudor Ambarus @ 2025-08-20 5:34 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski
Cc: linux-samsung-soc, Will Deacon, kernel-team, Catalin Marinas,
Conor Dooley, André Draszik, Alim Akhtar, devicetree,
willmcvicker, linux-arm-kernel, Peter Griffin, linux-kernel
On 8/19/25 4:22 PM, Rob Herring (Arm) wrote:
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250819-acpm-dvfs-dt-v1-0-4e38b95408c4@linaro.org:
>
> Error: arch/arm64/boot/dts/exynos/google/gs101.dtsi:75.32-33 Error: arch/arm64/boot/dts/exynos/google/gs101.dtsi:75.32-33 syntax errorsyntax error
Thanks, Rob.
I should have been more explicit in the cover letter. It fails because it depends
on the clock definitions that are introduced with the bindings in:
https://lore.kernel.org/linux-samsung-soc/20250819-acpm-clk-v1-0-6bbd97474671@linaro.org/T/#me3cbe2a97485d19eaf505ad23202f20a21305dd8
I chose to have the bindings with the driver patches as the clock definitions
are needed in the clock driver as well.
Krzysztof, please let me know if there's a preference on how to deal with such
dependencies, I'll note it down and respin if needed.
Thanks,
ta
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] arm64: dts: exynos: gs101: add CPU clocks
2025-08-19 12:10 ` [PATCH 2/3] arm64: dts: exynos: gs101: add CPU clocks Tudor Ambarus
@ 2025-08-24 17:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-24 17:01 UTC (permalink / raw)
To: Tudor Ambarus, Peter Griffin, André Draszik, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Catalin Marinas,
Will Deacon
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
willmcvicker, kernel-team
On 19/08/2025 14:10, Tudor Ambarus wrote:
> The GS101 CPU clocks are exposed through the ACPM protocol. Add them.
"Add GS101 CPU clocks exposed through ...".
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks
2025-08-19 12:10 ` [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks Tudor Ambarus
@ 2025-08-24 17:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-24 17:02 UTC (permalink / raw)
To: Tudor Ambarus, Peter Griffin, André Draszik, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Catalin Marinas,
Will Deacon
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
willmcvicker, kernel-team
On 19/08/2025 14:10, Tudor Ambarus wrote:
> Define the clocks exposed by the ACPM interface.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
This will need changes as discussed in the bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-08-24 18:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 12:10 [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Tudor Ambarus
2025-08-19 12:10 ` [PATCH 1/3] arm64: dts: exynos: gs101: add google,gs101-acpm-dvfs-clocks Tudor Ambarus
2025-08-24 17:02 ` Krzysztof Kozlowski
2025-08-19 12:10 ` [PATCH 2/3] arm64: dts: exynos: gs101: add CPU clocks Tudor Ambarus
2025-08-24 17:01 ` Krzysztof Kozlowski
2025-08-19 12:10 ` [PATCH 3/3] arm64: dts: exynos: gs101: add OPPs Tudor Ambarus
2025-08-19 15:22 ` [PATCH 0/3] arm64: dts: exynos: gs101: add cpufreq support Rob Herring (Arm)
2025-08-20 5:34 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).