Re: [PATCH v2 0/3] Samsung mfd/rtc driver alarm IRQ simplification

Lee Jones
2025-11-26T11:29:41Z

On Thu, 20 Nov 2025, André Draszik wrote:

> Hi,
>
> With the attached patches the Samsung s5m RTC driver is simplified a
> little bit with regards to alarm IRQ acquisition.
>
> The end result is that instead of having a list of IRQ numbers for each
> variant (and a BUILD_BUG_ON() to ensure consistency), the RTC driver
> queries the 'alarm' platform resource from the parent (mfd cell).
>
> Additionally, we can drop a now-useless field from runtime data,
> reducing memory consumption slightly.
>
> The attached patches must be applied in-order as patch 2 without 1 will
> fail at runtime, and patch 3 without 2 will fail at build time. I would
> expect them all to go via the MFD tree. Alternatively, they could be
> applied individually to the respective kernel trees during multiple
> kernel release cycles, but that seems a needless complication and
> delay.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Changes in v2:
> - rebase on top of https://lore.kernel.org/r/20251114-s2mpg10-chained-irq-v1-1-34ddfa49c4cd@linaro.org
> - return struct regmap_irq_chip_data * in sec_irq_init() (Lee)
> - collect tags
> - Link to v1: https://lore.kernel.org/r/20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org
>
> ---
> André Draszik (3):
> mfd: sec: add rtc alarm IRQ as platform device resource
> rtc: s5m: query platform device IRQ resource for alarm IRQ
> mfd: sec: drop now unused struct sec_pmic_dev::irq_data
>
> drivers/mfd/sec-common.c | 45 ++++++++++++++++++++--------
> drivers/mfd/sec-core.h | 2 +-
> drivers/mfd/sec-irq.c | 63 ++++++++++++++++++----------------------
> drivers/rtc/rtc-s5m.c | 21 +++++---------
> include/linux/mfd/samsung/core.h | 1 -
> 5 files changed, 71 insertions(+), 61 deletions(-)

The MFD parts look okay to me.

Once we have the RTC Ack, I'll merge this and send out a PR.

--
Lee Jones [李琼斯]