From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B625A41168D for ; Mon, 20 Jul 2026 15:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562054; cv=none; b=LzAoQauP2yjCdJ+RzF5AnF/GUvPREuLkfeBc1jHCB3+CZOhofnNNX/FOYszPjGtBG8iI9brma8ZZj4LOPkLI4iNd6saId7KlPWXLkaG4QeiEsbpZw3/qdonyTZFyR1e1Bh6u/R8EnYSMhXmV1C8nI6pVxe6w5buLZZ5ydl+xYeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562054; c=relaxed/simple; bh=FoTAnPb1lRoZPt5kTHzCnavIcMEf/gmxj2bw5UYVZDQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ti9PqkeGkYywDVN0ULa7UEnswvzG3zO6vMiM53FD02bCYXsf/Kk6oqAr0+VmhA9nOe2M7rYHylsFlUfx1Hl8G4tQffkSJqmw0Ko4LSgFZMcoj/hxX1Zzar5uzAZRv8yrhg0N/l8TfajYDZyckiYcfvpnGv5YsWZt3lMUAI1XDcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ht93hyzJ; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ht93hyzJ" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-476a130c138so6779639f8f.0 for ; Mon, 20 Jul 2026 08:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562050; x=1785166850; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=ht93hyzJwbxJrZBDf4Yi8if+v19nfi2fkw84WBPRBHQX3cDzWYU9Yg1wtupioMTE7V wxHnhMGwzhb973JoZZkkdUTtwHSynBL6GBHxvw86Zmx6Xf7qJ+9cmp2QjkOnVf8qvScu UFSPdnyyn51XtloUQo8lSO1zkiUZS9wuFruzw4CAz1lnE7NtAGov5ussz72oRGOSJRom NgT1dxxj7U0jiEZp0s/8kj78QeOZdreGi14zF0G4iFQR16Y/J2xcugNBGMkx5LbkXP0y aiglJsI+7gabJDCp2Uygwra131cOhOB/3JTHmA8qGghlNb+ZMPi7qLRPsIUbRst/FINM 3V2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562050; x=1785166850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=JzW14G+Lyck569Np57j8mKULuRsnyOJWK407iemCwjC+xAXgvVPGkuedYsE1tqFzcv 5hVp8aiDk9s2cwa5NwD76JcCOM+kyoaTzmGJT50UWRl9fZz8UysuBy1LlbsSBY5/3bn8 nBNK0BI+DcrfLPHI4ql39x+uUUOrfJT7voJhufHER2MdbpJM/qX62nVRDTa5lyyC9jBv pfUxzn81IFXOG4wOLnr3YGRFBSqpHLSreU00q5+tkjB59SDoKMvxXZTEdEXlRSqvp5Jq AWV16jnA03HQwvdfH43/rB7NKYo62DUG59GJcrSGp23GTZJ4MjncqnxA37loSsMdPf6p pwKg== X-Forwarded-Encrypted: i=1; AHgh+Ro0kZWbnQJRsp1tvccNcPrco6EwgR49MM6j6uP4amBc2KZlwtScp8z9v2Ee+n2Nr5ObrcNpN2SMqCgCBHTyPcS2ew==@vger.kernel.org X-Gm-Message-State: AOJu0YymFIKvb7IPu+3gunVr5kcBPoVY/LWULoO672blwxaQrvQs6rlW DiVtbyHwb8ek2K22BKnhvL3QeZX6fPrw2i6VxrGzhJMhvFDEy5KqsLoc X-Gm-Gg: AR+sD11jEo1oxXp/GDq7KYYpJMcBbMUMI7fVEq2R2ZPQ7UKcvuUBmXBvrIUc00ogL/Y PdU16bNaLHqXW/1ztaUgA2kiZvjSQsBidWPK8XtlYKPxrvILM0XBWPik9pGC3UT5zOc0r9P+465 PtsdR5k20K7Sl4FdO60WiqdFPglidx8ZRCLcRJiTHopwhFp/v2/8GSXbB0g61XNFdt9wh7vL4Ap 4E8bjMjym0lxKk6IxiHdZCHFHLob3U8isCTOY1FcaAQdz8E7hFTtZiSp7ziBtd61rJPeNPHE0u7 CmEkWraudb7sSCnuem2OjDWSYKSTQ7QOv+g+zz+ticsEFRSjHbtzWgOPlwMOwHAsAnHw0yTo5Gj MgFlN0KMo9y3sEpr7LnB+bpgjeQ2lXHmWlReFrhwpe/pPmFkMfQEi5uZpouXFgK7KZExlWR26Br 7v3llSAjZVOQ== X-Received: by 2002:a5d:5885:0:b0:46e:1815:6a83 with SMTP id ffacd0b85a97d-47f62318f12mr16050393f8f.29.1784562049630; Mon, 20 Jul 2026 08:40:49 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:49 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:33 +0200 Subject: [PATCH v2 01/15] drm/exynos: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-1-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 14 ++++++++++++-- 5 files changed, 54 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..957382223956 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + drm_err(drm_dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..de4a80158746 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include