From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers Date: Mon, 12 Aug 2013 13:14:20 +0200 Message-ID: <21180092.af8YMiXtjc@amdc1227> References: <1376302070-1877-1-git-send-email-padma.v@samsung.com> <1376302070-1877-2-git-send-email-padma.v@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:48092 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786Ab3HLLO0 (ORCPT ); Mon, 12 Aug 2013 07:14:26 -0400 In-reply-to: <1376302070-1877-2-git-send-email-padma.v@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Padmavathi Venna Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, padma.kvr@gmail.com, broonie@kernel.org, kgene.kim@samsung.com, tomasz.figa@gmail.com, abrestic@chromium.org Hi Padmavathi, Andrew, On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote: > From: Andrew Bresticker > > This adds device-tree bindings for the i2s controllers on Exynos 5420. > > Signed-off-by: Andrew Bresticker > Signed-off-by: Padmavathi Venna > Reviewed-on: https://gerrit.chromium.org/gerrit/57713 > --- > arch/arm/boot/dts/exynos5420.dtsi | 32 > ++++++++++++++++++++++++++++++++ 1 files changed, 32 insertions(+), 0 > deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index d2fdb87..8d57369 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -242,4 +242,36 @@ > pinctrl-names = "default"; > pinctrl-0 = <&i2c3_bus>; > }; > + > + i2s_0: i2s@03830000 { > + compatible = "samsung,exynos5420-i2s"; > + dmas = <&adma 0 > + &adma 2 > + &adma 1>; > + dma-names = "tx", "rx", "tx-sec"; > + clocks = <&clock_audss EXYNOS_I2S_BUS>, > + <&clock_audss EXYNOS_I2S_BUS>, > + <&clock_audss EXYNOS_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2s0_bus>; > + status = "disabled"; If a node does not require any board-specific properties for the device to operate properly, there is no point in disabling it, just to add a single status property at board level. > + }; > + > + i2s_1: i2s@12D60000 { > + clocks = <&clock 275>, <&clock 138>; > + clock-names = "iis", "i2s_opclk0"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2s1_bus>; > + status = "disabled"; Ditto. > + }; > + > + i2s_2: i2s@12D70000 { > + clocks = <&clock 276>, <&clock 139>; > + clock-names = "iis", "i2s_opclk0"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2s2_bus>; > + status = "disabled"; Ditto. Best regards, Tomasz