From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v7 03/25] iommu: Init iommu-groups support earlier, in core_initcall Date: Sat, 23 May 2015 19:23:34 +0300 Message-ID: <2209337.hhg3lyvUbi@avalon> References: <1432041645-11172-1-git-send-email-m.szyprowski@samsung.com> <1432041645-11172-4-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432041645-11172-4-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Marek Szyprowski Cc: Thierry Reding , Krzysztof Kozlowski , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaik Ameer Basha , Joonyoung Shim , Arnd Bergmann , Rob Herring , Inki Dae , Seung-Woo Kim , Will Deacon , Tomasz Figa , linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim , Kyungmin Park , Javier Martinez Canillas , Cho KyongHo , David Wodhouse , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org Hi Marek, Thank you for the patch. On Tuesday 19 May 2015 15:20:23 Marek Szyprowski wrote: > iommu_group_alloc might be called very early in case of iommu controllers > activated from of_iommu, so ensure that this part of subsystem is ready > when devices are being populated from device-tree (core_initcall seems to > be okay for this case). > > Signed-off-by: Marek Szyprowski > --- > drivers/iommu/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index d4f527e56679..37a6aa8f318b 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1207,7 +1207,7 @@ static int __init iommu_init(void) > > return 0; > } > -arch_initcall(iommu_init); > +core_initcall(iommu_init); I'll let Joerg comment on this, but this initcall ordering dance always makes me feel that something isn't quite right. Have you had a chance to look at the patch series I posted about a week ago to implement IOMMU probe deferral support ? > int iommu_domain_get_attr(struct iommu_domain *domain, > enum iommu_attr attr, void *data) -- Regards, Laurent Pinchart