From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
gustavo.padovan@collabora.co.uk, inki.dae@samsung.com
Subject: Re: drm/exynos: mixer blending and layer order
Date: Wed, 29 Apr 2015 15:13:21 +0200 [thread overview]
Message-ID: <229dcfe67a2ad84399cdc5090bca8cf8@math.uni-bielefeld.de> (raw)
In-Reply-To: <55407EF4.9090608@samsung.com>
Hey Joonyoung,
On 2015-04-29 08:49, Joonyoung Shim wrote:
> Without zpos, user may select hw layer only via plane resources order
> on
> latest exynos drm driver, but zpos can give obvious information to
> user.
> Of course we can improve zpos property or remove it or as you said
> change meaning for layer priority for better usage, but i just say what
> current codes mean.
Ok, I think I have some good idea how to properly fix this, but I guess
I should wait for Gustavos's plane cleanup to happen.
> I mean it can be invalidated when the layer has any above layers. To
> enable blending of layer can do regardless of opaque of behind layer,
> right? Please fix me if i misunderstand.
The plan is the following:
- For the bottom-most (enabled) layer we always disable any kind of
blending. We can make this more generic if we should expose
configuration of the background layer to userspace (but this is for the
future).
- For all other (enabled) layers we setup blending depending on the
pixelformat. If it's an alpha format, we enable blending, if not,
disable blending.
Does this sound correct?
Something we can keep in mind for the future:
Attach a 'global alpha' DRM property to each plane so that we can setup
blending even for non-alpha pixelformats. Range would be -1 to 0xff,
where -1 would mean 'disable global-alpha. This would expose the
MXR_GRP_CFG_WIN_BLEND_EN functionality.
> I already said it's ok to decide blending feature on/off of layer by
> pixel format.
Sorry, I misunderstood you there!
Also, maybe you can help me with this. The SoCs with no video processor
(so 'is_vp_enabled=0'), how many layers does the mixer support there? Is
it just one layer less (so no video layer), or is the video layer
replaced by a normal non-video layer? The current code implies that
there is one layer less, but I want to make sure I get this right! :)
With best wishes,
Tobias
next prev parent reply other threads:[~2015-04-29 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 12:28 drm/exynos: mixer blending and layer order Tobias Jakobi
2015-04-24 2:13 ` Joonyoung Shim
2015-04-24 8:29 ` Tobias Jakobi
2015-04-27 6:52 ` Joonyoung Shim
2015-04-28 12:58 ` Tobias Jakobi
2015-04-29 6:49 ` Joonyoung Shim
2015-04-29 13:13 ` Tobias Jakobi [this message]
2015-04-30 7:17 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229dcfe67a2ad84399cdc5090bca8cf8@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=gustavo.padovan@collabora.co.uk \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox