From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene@kernel.org Subject: RE: [PATCH 1/1] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Date: Sat, 04 Jan 2014 10:46:18 +0900 Message-ID: <22ed01cf08ee$c2ea08f0$48be1ad0$@kernel.org> References: <1388638630-1353-1-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:34180 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754501AbaADBqT (ORCPT ); Fri, 3 Jan 2014 20:46:19 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MYU00J9SSX5UW10@mailout3.samsung.com> for linux-samsung-soc@vger.kernel.org; Sat, 04 Jan 2014 10:46:17 +0900 (KST) In-reply-to: <1388638630-1353-1-git-send-email-sachin.kamat@linaro.org> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Sachin Kamat' , linux-mtd@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org, computersforpeace@gmail.com, patches@linaro.org Sachin Kamat wrote: > > plat/regs-nand.h is used only by S3C2410 nand driver. Since there > are no other users, merge this file into the driver code to remove > platform dependency. > > Signed-off-by: Sachin Kamat > --- > The earlier version of this patch was titled > "mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd". > Please ignore that. > --- > > arch/arm/plat-samsung/include/plat/regs-nand.h | 123 ------------------- > ----- > drivers/mtd/nand/s3c2410.c | 104 +++++++++++++++++++- > 2 files changed, 103 insertions(+), 124 deletions(-) > delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h > Moving looks good, but if some of them are not used, we don't need to keep them while moving. Thanks, Kukjin