Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, arnd@arndb.de,
	linus.walleij@stericsson.com, Kukjin Kim <kgene.kim@samsung.com>,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file
Date: Mon, 22 Jul 2013 21:25:35 +0200	[thread overview]
Message-ID: <2350088.9z671SCjFz@flatron> (raw)
In-Reply-To: <1374490361-25769-7-git-send-email-lee.jones@linaro.org>

Hi Lee,

On Monday 22 of July 2013 11:52:26 Lee Jones wrote:
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4210.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
> b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -72,7 +72,7 @@
>  		};
>  	};
> 
> -	clock: clock-controller@0x10030000 {
> +	clock: clock-controller@10030000 {
>  		compatible = "samsung,exynos4210-clock";
>  		reg = <0x10030000 0x20000>;
>  		#clock-cells = <1>;

This looks fine, but please fix commit message - it should be Exynos4210. 
Also some explanation why this change is needed would be good, even if 
it's obvious.

Best regards,
Tomasz

  reply	other threads:[~2013-07-22 19:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1374490361-25769-1-git-send-email-lee.jones@linaro.org>
2013-07-22 10:52 ` [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file Lee Jones
2013-07-22 19:25   ` Tomasz Figa [this message]
2013-07-23  8:55     ` Lee Jones
2013-07-23  9:32       ` Tomasz Figa
2013-07-24 12:39   ` [PATCH v2 07/22] ARM: Exynos4210: " Lee Jones
2013-07-24 14:03     ` Tomasz Figa
2013-07-24 15:05       ` Lee Jones
2013-07-24 15:09   ` [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 " Lee Jones
2013-07-24 15:24     ` Tomasz Figa
2013-07-25  7:52       ` Lee Jones
2013-08-05 17:58         ` Kukjin Kim
2013-08-05 18:07     ` Kukjin Kim
2013-08-06  7:18       ` Lee Jones
2013-07-22 10:52 ` [PATCH 08/22] ARM: dts: Remove '0x's from Exynos4x12 " Lee Jones
2013-07-22 10:52 ` [PATCH 09/22] ARM: dts: Remove '0x's from Exynos5250 DTS file Lee Jones
2013-07-22 10:52 ` [PATCH 10/22] ARM: dts: Remove '0x's from Exynos5420 " Lee Jones
2013-07-22 10:52 ` [PATCH 11/22] ARM: dts: Remove '0x's from Exynos5440 " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2350088.9z671SCjFz@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=arnd@arndb.de \
    --cc=kgene.kim@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox