From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA24C433EF for ; Mon, 27 Jun 2022 10:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232597AbiF0KeA (ORCPT ); Mon, 27 Jun 2022 06:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233808AbiF0Kd7 (ORCPT ); Mon, 27 Jun 2022 06:33:59 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74A29641A for ; Mon, 27 Jun 2022 03:33:54 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id d17so6754721wrc.10 for ; Mon, 27 Jun 2022 03:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Fu4PRWXrnet8l+Wzlc9u5ZP+FAA0ZHxV8ImVTD46fu4=; b=v4ZXKOx56aXRHkRYD+3x19r45JbK0YB5ZD6H6BW7wTKUW7Jmb0uEWElqEXZpNcm+Mc PqsE+9O2TIYI38NY1HFnw5toFCep++jR44ayUMC9rUEU6w/lingU/+iahFPk+/8CZgAx 1FiefvUiwks8IlnPzSXvNk4706pFoTlwUAx3zDoAOjLhLLhBWQpq92dOmCWsLCMIijTa qn0nZ0PIHB0LznFuoZsTIDmiVQx+9/ivpBhy49cQL0K2moY63HVy0RPGNwu4fZwBBgOh fI77xGIINwf5yBMK1iA4RZknY0WzwDhWOGjH/0/RqUPANuNzPLSlYm2qiRdJKp0IPbJg 2dCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Fu4PRWXrnet8l+Wzlc9u5ZP+FAA0ZHxV8ImVTD46fu4=; b=jtDcnfjeTofEPdZOvgYgfMlA5N6PhdNE3pmVkgLL5DNh8sop+4eLAlK+vopbMymn/l c454p6b378riVbKD1HMz603l6UEf7aPuvlnGjm0qQGxQJcyYBMIZ6kUevdokZmrFufdi Tn706AwoYTLKPx6GZgN6BMRZY6+pm4NkFEmo9ZqGsCP3laYsP7qRJYbhNeZPcMFXatYC pZnoLju/Y8V7PsUj4ZrGzrOp8ECpg/PDWnaw070d5A/DnM9AlC2bgNDyY0lLsG/9vBKA Bum2+hrhoQMhwJ3sFAuveI3wgQtj20tJi4iDdRRGdojv1v5FbP+OxqNmA8jHZIuRoDJd K4Fw== X-Gm-Message-State: AJIora89/GBuG42xx4tfvSN+EVLgGCuHUufqvip/VDKKr69ENY/EEs2a 9fn4eaUvgQQvQ8CuGkXi8TKUJPzXAj8mcw== X-Google-Smtp-Source: AGRyM1vrMf7GTnVelKxnSwRHWWbdVw3djaiQiOu0uxngmY4+SVTXF6d/YiYWRDu9588N45dwC8jkUw== X-Received: by 2002:a5d:64cc:0:b0:21b:ba06:4d4d with SMTP id f12-20020a5d64cc000000b0021bba064d4dmr11794574wri.157.1656326032961; Mon, 27 Jun 2022 03:33:52 -0700 (PDT) Received: from [192.168.0.248] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 4-20020a1c1904000000b0039c4506bd25sm15039945wmz.14.2022.06.27.03.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 03:33:52 -0700 (PDT) Message-ID: <2efd725f-3d99-c1df-23ce-9ee60bbe4600@linaro.org> Date: Mon, 27 Jun 2022 12:33:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] tty: serial: samsung_tty: support more than 4 uart ports Content-Language: en-US To: Chanho Park , Greg Kroah-Hartman Cc: Jiri Slaby , Alim Akhtar , Hector Martin , Jaewon Kim , Vincent Whitchurch , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220627071512.18180-1-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220627071512.18180-1-chanho61.park@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 27/06/2022 09:15, Chanho Park wrote: > Regarding Exynos Auto v9 SoC, it supports uarts up to 12. However, the > maximum number of the ports has been derived from > CONFIG_SERIAL_SAMSUNG_UARTS and tightly coupled with the config for > previous Samsung SoCs such as s3c24xx and s3c64xx. To overcome this > limitation, this changes the usage of the definition to UART_NR which is > widely used from other serial drivers. This also defines the value to 12 > only for ARM64 SoCs to not affect the change to previous arm32 SoCs. > Instead of enumerating all the ports as predefined arrays, this > introduces s3c24xx_serial_init_port_default that is initializing the > structure as default value. > Regarding the ports which are greater than 4 > will be initialized as default value and the fifo size will be retrieved > from the DT property. You need to explain why you are doing this. It's confusing to initialize some statically and some dynamically. Best regards, Krzysztof