Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	dianders@chromium.org, jg1.han@samsung.com,
	sachin.kamat@linaro.org
Subject: Re: [PATCH V3] watchdog: s3c2410_wdt: remove the global variables
Date: Tue, 23 Jul 2013 13:19:48 +0200	[thread overview]
Message-ID: <3101567.pnRdvXvbY0@amdc1227> (raw)
In-Reply-To: <1374569985-13576-1-git-send-email-l.krishna@samsung.com>

Hi,

On Tuesday 23 of July 2013 14:29:45 Leela Krishna Amudala wrote:
> This patch removes the global variables in the driver file and
> group them into a structure.
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  Note: This patch is rebased on kgene's for-next branch and tested on
> SMDK5420.
> 
>  Changes since V2:
> 	- Addressed comments given by Tomasz Figa <t.figa@samsung.com>
> 	  https://patchwork.kernel.org/patch/2831032/
> 	- Renamed structure name from s3c2410_watchdog to s3c2410_wdt.
> 
>  Changes since V1:
> 	- changed the patch subject.
> 	- indentation correction in s3c2410_watchdog structure.
> 
>  drivers/watchdog/s3c2410_wdt.c |  225
> +++++++++++++++++++++++----------------- 1 file changed, 131
> insertions(+), 94 deletions(-)

Looks good to me, thanks.

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

  reply	other threads:[~2013-07-23 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  8:59 [PATCH V3] watchdog: s3c2410_wdt: remove the global variables Leela Krishna Amudala
2013-07-23 11:19 ` Tomasz Figa [this message]
2013-07-24  7:53 ` Kukjin Kim
2013-07-30  6:05   ` Leela Krishna Amudala
2013-08-12  6:20     ` Leela Krishna Amudala
2013-08-23 14:49     ` Wim Van Sebroeck
2013-08-27  9:47       ` Leela Krishna Amudala
2013-08-21 20:01   ` Wim Van Sebroeck
2013-08-21 21:22     ` Guenter Roeck
2013-08-23 14:34       ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3101567.pnRdvXvbY0@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=dianders@chromium.org \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=l.krishna@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox