From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23093C433B4 for ; Fri, 16 Apr 2021 09:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E00FE6113B for ; Fri, 16 Apr 2021 09:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239783AbhDPJOR (ORCPT ); Fri, 16 Apr 2021 05:14:17 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59531 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235101AbhDPJOQ (ORCPT ); Fri, 16 Apr 2021 05:14:16 -0400 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lXKXv-0007L9-Ht for linux-samsung-soc@vger.kernel.org; Fri, 16 Apr 2021 09:13:51 +0000 Received: by mail-ed1-f70.google.com with SMTP id l22-20020a0564021256b0290384ebfba68cso2815463edw.2 for ; Fri, 16 Apr 2021 02:13:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TBHSrQMedfIZ0NHm4Vuee3oMabjgi2Z9z+wuaFSao34=; b=MJD2EilbcCvMFexmOHnSugMb/Z0vNyr/z2S6LZyz+TXL7uZQHMsnxmvkk1v/NDJ8S4 TxdBOGn8HAuftUO4sOQf/tWhcS22tHcKdm9xKWIfbumMowAIxdceM8W38XRUwi1pWRKp ShM6jFcIExRX5ttAsivLkjJYR1DLnPp9HnaQuFEzgSwymiiuQbzUfXBCIlchz6Nhx6w5 aCLBG/MCXm/GeWTK4KLCfoQdXHnCjv8qyAHY1sJ3RPWPczvaaZCaeRhRs9hbwWxwM5FS AmKJOBQcLUw5oR8uzWmOldVUP3zDcik1ggV3X3/7LGu3EQ2RURJlkhkxuJo7Bc7B+V1O g3VQ== X-Gm-Message-State: AOAM5330sgWkB3nr76ytZDQSBlF3kHr4VcShEEqGX+zU9fOz/oLducpP +QuzycnkvbzEEpwHXTNlErMorx7NT/mvarhKZ5sgLJMeN0a1iU8wahs8MWdnP4uoXdYWuw7gk5S 2Qc5keraxmOEa/3Ub8Lya2cdr20ixIUwZKYdEYnrZzGLMco8R X-Received: by 2002:a17:906:53c7:: with SMTP id p7mr7337267ejo.89.1618564430903; Fri, 16 Apr 2021 02:13:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweK9tiB7uzLCIeFzW76R/mM0DO97HxN0N8y+fVULfDExeD0z+87Y25+JwAgl7DxkP3goJkpA== X-Received: by 2002:a17:906:53c7:: with SMTP id p7mr7337261ejo.89.1618564430799; Fri, 16 Apr 2021 02:13:50 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id m10sm3830584ejc.32.2021.04.16.02.13.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 02:13:50 -0700 (PDT) Subject: Re: [PATCH] rtc: Fix missing IRQF_ONESHOT as only threaded handler To: zhuguangqing83@gmail.com, Alessandro Zummo , Alexandre Belloni , Chanwoo Choi , Bartlomiej Zolnierkiewicz Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20210416021949.1569-1-zhuguangqing83@gmail.com> From: Krzysztof Kozlowski Message-ID: <342f2c09-87a8-571e-e032-d954de4cf2fc@canonical.com> Date: Fri, 16 Apr 2021 11:13:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416021949.1569-1-zhuguangqing83@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 16/04/2021 04:19, zhuguangqing83@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > 1. drivers/rtc/rtc-s5m.c:810:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 2. drivers/rtc/rtc-rk808.c:441:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 3. drivers/rtc/rtc-max77686.c:779:7-27: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 4. drivers/rtc/rtc-tps65910.c:415:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 5. drivers/rtc/rtc-lp8788.c:277:8-33: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 6. drivers/rtc/rtc-max8998.c:283:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 7. drivers/rtc/rtc-rc5t583.c:241:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 8. drivers/rtc/rtc-max8997.c:495:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu > --- > drivers/rtc/rtc-lp8788.c | 2 +- > drivers/rtc/rtc-max77686.c | 4 ++-- > drivers/rtc/rtc-max8997.c | 2 +- > drivers/rtc/rtc-max8998.c | 3 ++- > drivers/rtc/rtc-rc5t583.c | 2 +- > drivers/rtc/rtc-rk808.c | 2 +- > drivers/rtc/rtc-s5m.c | 4 ++-- The commit msg suggests in misleading way that there is an issue here to solve but at least for max* and s5m it is not true. These are nested interrupts. I tested *only* the S5M: Tested-by: Krzysztof Kozlowski but still I wonder - why this change is needed, except satisfying blind Coccinelle runs? Does it really bring benefit for the nested interrupts? Best regards, Krzysztof