From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Date: Mon, 11 Jul 2016 13:40:45 +0200 Message-ID: <4080443.gtvsF1A0TV@wuerfel> References: <20160627110303.3391769-1-arnd@arndb.de> <57710F1F.8090304@samsung.com> <1807726.lxvlsY5ymW@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([217.72.192.74]:54343 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276AbcGKLh5 (ORCPT ); Mon, 11 Jul 2016 07:37:57 -0400 In-Reply-To: <1807726.lxvlsY5ymW@wuerfel> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Kefeng Wang , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote: > On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote: > > On 06/27/2016 01:02 PM, Arnd Bergmann wrote: > > > The change to simplify of_platform_populate() had an unintended > > > side-effect of introducing a build warning on s3c64xx: > > > > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0: > > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > > > > > This adds a forward-declaration for the structure name in the > > > header to avoid the warning. > > > > > > Signed-off-by: Arnd Bergmann > > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table") > > > --- > > > Rob, can you apply this on top of the devicetree git so we don't > > > have to coordinate the merges? > > > > Acked-by: Krzysztof Kozlowski > > Hi Rob, > > I still get the warning in every linux-next build, do you plan to pick > up the fix for the commit you merged, or should I try to work around it > in arm-soc and leave this as a bisection problem? > Now with Rob back on Cc. Arnd