From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: SAMSUNG: Add DMA masks to hsotg device
Date: Fri, 29 Jan 2010 12:56:19 +0300 [thread overview]
Message-ID: <4B62B0C3.2090705@ru.mvista.com> (raw)
In-Reply-To: <1264738459-1972-2-git-send-email-ben-linux@fluff.org>
Hello.
Ben Dooks wrote:
> Add the required DMA masks to the hs-otg device definition to allow DMA
> to work with it.
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> ---
> arch/arm/plat-samsung/dev-usb-hsotg.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/dev-usb-hsotg.c b/arch/arm/plat-samsung/dev-usb-hsotg.c
> index e2f604b..d8b7870 100644
> --- a/arch/arm/plat-samsung/dev-usb-hsotg.c
> +++ b/arch/arm/plat-samsung/dev-usb-hsotg.c
> @@ -33,9 +33,15 @@ static struct resource s3c_usb_hsotg_resources[] = {
> },
> };
>
> +static u64 s3c_hsotg_dmamask = 0xffffffffUL;
> +
>
Shouldn't this be DMA_BIT_MASK(32)?
> struct platform_device s3c_device_usb_hsotg = {
> .name = "s3c-hsotg",
> .id = -1,
> .num_resources = ARRAY_SIZE(s3c_usb_hsotg_resources),
> .resource = s3c_usb_hsotg_resources,
> + .dev = {
> + .dma_mask = &s3c_hsotg_dmamask,
> + .coherent_dma_mask = 0xffffffffUL,
>
Same here...
WBR, Sergei
next prev parent reply other threads:[~2010-01-29 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 4:14 Samsung device updates Ben Dooks
2010-01-29 4:14 ` [PATCH] ARM: SAMSUNG: Add DMA masks to hsotg device Ben Dooks
2010-01-29 9:56 ` Sergei Shtylyov [this message]
2010-01-29 4:14 ` [PATCH] ARM: S3C64XX: SPI: Make platform device compilation selectable Ben Dooks
2010-01-29 4:14 ` [PATCH] ARM: S3C2412: SoC has the fractional baud rate register Ben Dooks
2010-01-29 4:14 ` [PATCH] ARM: SAMSUNG: Add SERIAL_SAMSUNG_UARTS_4 Kconfig option Ben Dooks
2010-01-29 4:14 ` [PATCH] ARM: SAMSUNG: Use PLAT_SAMSUNG instead of PLAT_S3C Ben Dooks
2010-01-29 4:14 ` [PATCH] ARM: S3C64XX: Make audio device code built unconditionally Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B62B0C3.2090705@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox