From: Maurus Cuelenaere <mcuelenaere@gmail.com>
To: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org
Cc: ben-linux@fluff.org, a.zummo@towertech.it, p_gortmaker@yahoo.com,
Jiri.Pinkava@vscht.cz, akpm@linux-foundation.org
Subject: [PATCH 1/2] RTC: s3c: Initialize driver data before using it
Date: Thu, 27 May 2010 23:28:45 +0200 [thread overview]
Message-ID: <4BFEE40D.4030807@gmail.com> (raw)
In-Reply-To: <cover.1274994983.git.mcuelenaere@gmail.com>
s3c_rtc_setfreq() uses the platform driver data to derive struct rtc_device,
so make sure drvdata is set _before_ s3c_rtc_setfreq() is called.
Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
drivers/rtc/rtc-s3c.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index e5972b2..6adebf3 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -495,8 +495,6 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev)
pr_debug("s3c2410_rtc: RTCCON=%02x\n",
readb(s3c_rtc_base + S3C2410_RTCCON));
- s3c_rtc_setfreq(&pdev->dev, 1);
-
device_init_wakeup(&pdev->dev, 1);
/* register RTC and exit */
@@ -518,6 +516,9 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev)
s3c_rtc_cpu_type = platform_get_device_id(pdev)->driver_data;
platform_set_drvdata(pdev, rtc);
+
+ s3c_rtc_setfreq(&pdev->dev, 1);
+
return 0;
err_nortc:
--
1.7.1
next parent reply other threads:[~2010-05-27 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1274994983.git.mcuelenaere@gmail.com>
2010-05-27 21:28 ` Maurus Cuelenaere [this message]
2010-05-27 21:51 ` [PATCH 1/2] RTC: s3c: Initialize driver data before using it Andrew Morton
2010-05-27 21:28 ` [PATCH 2/2] RTC: s3c: Initialize s3c_rtc_cpu_type " Maurus Cuelenaere
2010-05-27 21:52 ` Andrew Morton
2010-05-27 21:55 ` Maurus Cuelenaere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFEE40D.4030807@gmail.com \
--to=mcuelenaere@gmail.com \
--cc=Jiri.Pinkava@vscht.cz \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox